Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anti-evil-maid-dump-evt-log: add parsers fot TPM event log #7

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

krystian-hebel
Copy link
Member

This was tested both with TXT and firmware event logs. Log must be passed as a regular file, so neither piping it as stdin nor supplying /sys/kernel/security/tpm0/binary_bios_measurements directly works.

@krystian-hebel krystian-hebel force-pushed the event_log branch 2 times, most recently from 0662771 to 83d6422 Compare December 12, 2023 14:37
@krystian-hebel krystian-hebel changed the title tpm2-evt-log-parser.awk: add parser fot TPM 2.0 event log anti-evil-maid-dump-evt-log: add parsers fot TPM event log Dec 14, 2023
Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least TPM2 log parsing works for me as well (didn't check TXT TPM1 format), but I think there are a few things to adjust.

sbin/anti-evil-maid-dump-evt-log Outdated Show resolved Hide resolved
sbin/txt-tpm1-evt-log-parser.awk Outdated Show resolved Hide resolved
sbin/tpm2-evt-log-parser.awk Outdated Show resolved Hide resolved
sbin/tpm2-evt-log-parser.awk Outdated Show resolved Hide resolved
sbin/txt-tpm1-evt-log-parser.awk Outdated Show resolved Hide resolved
sbin/tpm2-evt-log-parser.awk Outdated Show resolved Hide resolved
sbin/anti-evil-maid-dump-evt-log Outdated Show resolved Hide resolved
sbin/tpm2-evt-log-parser.awk Show resolved Hide resolved
sbin/tpm2-evt-log-parser.awk Outdated Show resolved Hide resolved
Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One more spelling nit: first commit (and title of this PR) says fot instead of for.

sbin/anti-evil-maid-dump-evt-log Show resolved Hide resolved
sbin/tpm2-evt-log-parser.awk Show resolved Hide resolved
sbin/txt-tpm1-evt-log-parser.awk Show resolved Hide resolved
This was tested both with TXT and firmware event logs. Log must be
passed as a regular file, so neither piping it as stdin nor supplying
/sys/kernel/security/tpm0/binary_bios_measurements directly works.

Signed-off-by: Krystian Hebel <[email protected]>
Contrary to TPM 2.0 format, this one is specific to Intel TXT and
cannot be used for parsing firmware entries, hence the seemingly
inconsistent file name. Similarly to TPM 2.0 parser, this one also
must operate on regular file.

Signed-off-by: Krystian Hebel <[email protected]>
@krystian-hebel
Copy link
Member Author

krystian-hebel commented Dec 18, 2023

LGTM. One more spelling nit: first commit (and title of this PR) says fot instead of for.

Fixed https://github.com/TrenchBoot/qubes-antievilmaid/compare/2ccd86f8c75b9c905ff792c1b06f3de7bbf96361..3f2d00f86feb3335e5326ad25a77980b9d087374 (seems that GH doesn't care about commit messages)

@miczyg1 miczyg1 merged commit 3f2d00f into main Dec 21, 2023
1 check passed
@SergiiDmytruk SergiiDmytruk deleted the event_log branch December 21, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants