-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anti-evil-maid-dump-evt-log: add parsers fot TPM event log #7
Conversation
0662771
to
83d6422
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least TPM2 log parsing works for me as well (didn't check TXT TPM1 format), but I think there are a few things to adjust.
83d6422
to
2ccd86f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One more spelling nit: first commit (and title of this PR) says fot
instead of for
.
This was tested both with TXT and firmware event logs. Log must be passed as a regular file, so neither piping it as stdin nor supplying /sys/kernel/security/tpm0/binary_bios_measurements directly works. Signed-off-by: Krystian Hebel <[email protected]>
Contrary to TPM 2.0 format, this one is specific to Intel TXT and cannot be used for parsing firmware entries, hence the seemingly inconsistent file name. Similarly to TPM 2.0 parser, this one also must operate on regular file. Signed-off-by: Krystian Hebel <[email protected]>
2ccd86f
to
3f2d00f
Compare
Fixed https://github.com/TrenchBoot/qubes-antievilmaid/compare/2ccd86f8c75b9c905ff792c1b06f3de7bbf96361..3f2d00f86feb3335e5326ad25a77980b9d087374 (seems that GH doesn't care about commit messages) |
This was tested both with TXT and firmware event logs. Log must be passed as a regular file, so neither piping it as stdin nor supplying /sys/kernel/security/tpm0/binary_bios_measurements directly works.