Implement SaveExistingSpawns and lookup of existing spawns #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i kinda recall that i tried this a few months ago and it wasn't working much, as the offset varied a lot due to mysql rounding - is this still the case? |
|
Well i mitigated it with the round sql in this pr. Its down to a manageable level. Used it this weekend to get all spawns in azuremyst isle across 7 sniffs. |
killerwife
force-pushed
the
feature/ExistingSpawns
branch
from
c9eb46d to
789b3f8
Compare
killerwife
commented
Dec 27, 2023
WowPacketParser/App.config
Outdated
| Description: Spawn spawns which are already existing in db (compared by entry, position) or comment them in sql | ||
| Default: "false" (comment existing spawns in sql) | ||
| --> | ||
| <add key="SaveExistingSpawns" value="false"/> |
There was a problem hiding this comment.
@mdX7 prolly just one thing, default should be True, thats the old behaviour. Forgot to change that.
There was a problem hiding this comment.
Im going with default false, makes it easier for new people using wpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This features enables sorting through sniffs in quick succession for subsequent missing spawns without requiring to insert everything into the database. Lines which are already found in db will be commented out optionally.
This is not usable across all patches, I found that for example draenei island shifted by 0.2 in X coordinate for whatever reason, comparing Legion vs Wotlk Classic data, however for using same expansion data its very useful when tracking down missing spawns.
I use a precision of 0.000001f for comparison, because due to serialization and decimal loading and other shenanigans, mysql float is no longer able to fit exact equal value after 15th decimal on average. This is not worth reworking the database columns, however it does mean that == operator is not usable.
Optionally, I can add designation between TC and Cmangos schema, for now I made TBC conform with our db schema as a workaround and kept the rest conforming with wotlk+ for TC.