Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add important note about headnode domain name, and the following sections: a) Setup SDC-Docker, b) Configure Client Access to CloudAPI #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joyent-automation
Copy link

Add important note about headnode domain name, and the following sections: a) Setup SDC-Docker, b) Configure Client Access to CloudAPI

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/925/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@khangngu commented at 2018-12-17T23:55:35

Patch Set 1: Code-Review+1

@khangngu commented at 2018-12-17T23:55:57

Removed the following votes:

  • CI-Testing+1 by Joyent Automation (1000005)
@johnlevon commented at 2018-12-20T16:36:17

Patch Set 1:

(2 comments)

Patch Set 1 code comments
docs/developer-guide/coal-setup.md#150 @johnlevon

"alphanumeric"?

docs/developer-guide/coal-setup.md#383 @johnlevon

"Substitute"?

…ions: a) Setup SDC-Docker, b) Configure Client Access to CloudAPI
|Confirm "root" password|||
|"admin" password|adminpass1||
|"admin" password|adminpass1|Enter aphanumeric characters. Do not use space or special characters.|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Password parsing was fixed in OS-7361 (joyent/sdc-headnode@ b5c0e5a5f6e0ed31c6db2573de9b720d851af603), so these comments on passwords are unnecessary (and dangerous).

|Region of Datacenter|orbit||
|Name of Datacenter|coal-1|(Availability zone.) |
|Region of Datacenter|orbit|Enter aphanumeric characters. Do not use space or special characters.|
|Name of Datacenter|coal-1|Enter aphanumeric characters. Do not use space or special characters.|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be something like "must be DNS name compliant strings".

@@ -313,8 +313,7 @@ global running smartlogin online
adminui0 10.99.99.31 10.88.88.3
```

We can now access access the operations portal, "SDC ADMINUI", in a web
browser on the host computer at https://10.88.88.3/ .
You can now access the Operations Portal (SDC ADMINUI) in a web browser on the host computer at <https://10.88.88.3>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All prose should be hard wrapped prior to 80 columns for readability in terminals.

# Add the SSH key. Substiture real value for {username}.
sdc-useradm add-key {username} /var/tmp/id_rsa.pub
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 348 to 386: All prose should be hard wrapped prior to 80 columns for readability in terminals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants