Merge pull request #99 from TrustNXT/bugfix/bmff-extents

BMFF: Fix shifting of extents
TrustNXT · Sep 9, 2024 · dc77867 · dc77867
2 parents 2b3f44b + 3464be0
commit dc77867
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/dry-crews-warn.md b/.changeset/dry-crews-warn.md
@@ -0,0 +1,5 @@
+---
+'@trustnxt/c2pa-ts': patch
+---
+
+BMFF: Fix adjustment of extents in iloc box
diff --git a/src/asset/BMFF.ts b/src/asset/BMFF.ts
@@ -528,7 +528,7 @@ class ItemLocationBox extends FullBox<ItemLocationBoxPayload> {
 
         for (const item of this.payload.items) {
             pos += this.payload.version === 2 ? 4 : 2; // item_ID
-            if (this.payload.version > 0) pos++; // reserved, construction_method
+            if (this.payload.version > 0) pos += 2; // reserved, construction_method
             pos += 2; // data_reference_index
             if (this.payload.baseOffsetSize === 8) {
                 item.baseOffset = (item.baseOffset as bigint) + BigInt(amount);
@@ -543,8 +543,8 @@ class ItemLocationBox extends FullBox<ItemLocationBoxPayload> {
             for (const extent of item.extents) {
                 if (this.payload.indexSize) pos += this.payload.indexSize;
                 if (
-                    (item.constructionMethod ??
-                        ItemLocationConstructionMethod.file === ItemLocationConstructionMethod.file) &&
+                    (item.constructionMethod ?? ItemLocationConstructionMethod.file) ===
+                        ItemLocationConstructionMethod.file &&
                     item.baseOffset === 0 &&
                     extent.offset !== 0
                 ) {