Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2PA v2.1 Updates - ingredients assertion v3 #202

Merged
merged 21 commits into from
Jan 13, 2025

Conversation

karlobencic
Copy link
Contributor

This PR includes several important updates to improve validation and error handling in the C2PA SDK according to v2.1 specification:

Key Changes

  • New c2pa URN namespace for labelling manifests
  • New ingredients v3 assertion
  • Updated validation status codes with more specific error categories
  • Improved ingredient assertion validation and relationship handling
  • Added validation for manifest relationships and ingredients
  • Reorganized validation logic in Manifest class

@karlobencic karlobencic requested a review from cyraxx January 3, 2025 14:59
Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: d4f3392

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@trustnxt/c2pa-ts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cyraxx
Copy link
Contributor

cyraxx commented Jan 3, 2025

Open tasks:

  • Add JSDoc comments for newly created methods
  • Implement assertion.undeclared validation (go through all assertions in assertion store and make sure they're referenced by the claim's created or gathered assertions)
  • Revisit validation of redactions (zeroed out) – likely to be moved to a new issue unless we can get example data

src/manifest/assertions/IngredientAssertion.ts Outdated Show resolved Hide resolved
src/manifest/assertions/IngredientAssertion.ts Outdated Show resolved Hide resolved
src/manifest/assertions/IngredientAssertion.ts Outdated Show resolved Hide resolved
src/manifest/assertions/IngredientAssertion.ts Outdated Show resolved Hide resolved
@karlobencic karlobencic marked this pull request as ready for review January 11, 2025 14:43
Copy link
Contributor

@cyraxx cyraxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, great job!

Just need to make sure we keep track of the two remaining action items: assertion.undeclared validation and validation of redactions.

@karlobencic karlobencic merged commit 097fab2 into main Jan 13, 2025
3 checks passed
@karlobencic karlobencic deleted the feature/ingredients-assertion-v3 branch January 13, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants