Skip to content

Commit

Permalink
Fixed missing global:: prefix for the underlying callee. (#47)
Browse files Browse the repository at this point in the history
  • Loading branch information
Tum4ik authored May 29, 2024
1 parent b2bbba3 commit 04dc773
Show file tree
Hide file tree
Showing 11 changed files with 128 additions and 168 deletions.
2 changes: 1 addition & 1 deletion SolutionProperties/ReleaseNotes.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
- Updated Microsoft.CodeAnalysis.CSharp.Workspaces package.
- Fixed missing `global::` prefix for the underlying callee.
40 changes: 20 additions & 20 deletions Tests/Tum4ik.StinimGen.Specs/Features/Event/Event.feature
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ Scenario: Event field with EventHandler type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.EventMember"/>
/// <inheritdoc cref = "global::Events.EventHolder.EventMember"/>
event global::System.EventHandler EventMember;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::System.EventHandler EventMember { add => Events.EventHolder.EventMember += value; remove => Events.EventHolder.EventMember -= value; }
public event global::System.EventHandler EventMember { add => global::Events.EventHolder.EventMember += value; remove => global::Events.EventHolder.EventMember -= value; }
"""


Expand All @@ -51,13 +51,13 @@ Scenario: Event field with custom type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.EventMember"/>
/// <inheritdoc cref = "global::Events.EventHolder.EventMember"/>
event global::Events.CustomEventHandler EventMember;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::Events.CustomEventHandler EventMember { add => Events.EventHolder.EventMember += value; remove => Events.EventHolder.EventMember -= value; }
public event global::Events.CustomEventHandler EventMember { add => global::Events.EventHolder.EventMember += value; remove => global::Events.EventHolder.EventMember -= value; }
"""


Expand All @@ -70,13 +70,13 @@ Scenario: Event field with Action type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.EventMember"/>
/// <inheritdoc cref = "global::Events.EventHolder.EventMember"/>
event global::System.Action EventMember;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::System.Action EventMember { add => Events.EventHolder.EventMember += value; remove => Events.EventHolder.EventMember -= value; }
public event global::System.Action EventMember { add => global::Events.EventHolder.EventMember += value; remove => global::Events.EventHolder.EventMember -= value; }
"""


Expand All @@ -89,13 +89,13 @@ Scenario: Event field with Action type with keyworded generic parameter
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.EventMember"/>
/// <inheritdoc cref = "global::Events.EventHolder.EventMember"/>
event global::System.Action<int> EventMember;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::System.Action<int> EventMember { add => Events.EventHolder.EventMember += value; remove => Events.EventHolder.EventMember -= value; }
public event global::System.Action<int> EventMember { add => global::Events.EventHolder.EventMember += value; remove => global::Events.EventHolder.EventMember -= value; }
"""


Expand All @@ -108,13 +108,13 @@ Scenario: Event field with Action type with keyworded nullable generic parameter
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.EventMember"/>
/// <inheritdoc cref = "global::Events.EventHolder.EventMember"/>
event global::System.Action<string?> EventMember;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::System.Action<string?> EventMember { add => Events.EventHolder.EventMember += value; remove => Events.EventHolder.EventMember -= value; }
public event global::System.Action<string?> EventMember { add => global::Events.EventHolder.EventMember += value; remove => global::Events.EventHolder.EventMember -= value; }
"""


Expand All @@ -127,13 +127,13 @@ Scenario: Event field with Action type with non-keyworded generic parameter
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.EventMember"/>
/// <inheritdoc cref = "global::Events.EventHolder.EventMember"/>
event global::System.Action<global::System.DateTime> EventMember;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::System.Action<global::System.DateTime> EventMember { add => Events.EventHolder.EventMember += value; remove => Events.EventHolder.EventMember -= value; }
public event global::System.Action<global::System.DateTime> EventMember { add => global::Events.EventHolder.EventMember += value; remove => global::Events.EventHolder.EventMember -= value; }
"""


Expand All @@ -146,13 +146,13 @@ Scenario: Event field with Action type with non-keyworded nullable generic param
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.EventMember"/>
/// <inheritdoc cref = "global::Events.EventHolder.EventMember"/>
event global::System.Action<global::System.DayOfWeek?> EventMember;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::System.Action<global::System.DayOfWeek?> EventMember { add => Events.EventHolder.EventMember += value; remove => Events.EventHolder.EventMember -= value; }
public event global::System.Action<global::System.DayOfWeek?> EventMember { add => global::Events.EventHolder.EventMember += value; remove => global::Events.EventHolder.EventMember -= value; }
"""


Expand All @@ -165,13 +165,13 @@ Scenario: Event field with Func
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.EventMember"/>
/// <inheritdoc cref = "global::Events.EventHolder.EventMember"/>
event global::System.Func<global::System.DayOfWeek?, double, int?> EventMember;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::System.Func<global::System.DayOfWeek?, double, int?> EventMember { add => Events.EventHolder.EventMember += value; remove => Events.EventHolder.EventMember -= value; }
public event global::System.Func<global::System.DayOfWeek?, double, int?> EventMember { add => global::Events.EventHolder.EventMember += value; remove => global::Events.EventHolder.EventMember -= value; }
"""


Expand All @@ -189,13 +189,13 @@ Scenario: Full event
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.FullEvent"/>
/// <inheritdoc cref = "global::Events.EventHolder.FullEvent"/>
event global::System.EventHandler FullEvent;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public event global::System.EventHandler FullEvent { add => Events.EventHolder.FullEvent += value; remove => Events.EventHolder.FullEvent -= value; }
public event global::System.EventHandler FullEvent { add => global::Events.EventHolder.FullEvent += value; remove => global::Events.EventHolder.FullEvent -= value; }
"""


Expand All @@ -209,13 +209,13 @@ Scenario: Forward Obsolete attribute
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Events.EventHolder.ObsoleteEvent"/>
/// <inheritdoc cref = "global::Events.EventHolder.ObsoleteEvent"/>
[global::System.ObsoleteAttribute("Obsolete event")]
event global::System.EventHandler ObsoleteEvent;
"""
And generated implementation member must be
"""
/// <inheritdoc/>
[global::System.ObsoleteAttribute("Obsolete event")]
public event global::System.EventHandler ObsoleteEvent { add => Events.EventHolder.ObsoleteEvent += value; remove => Events.EventHolder.ObsoleteEvent -= value; }
public event global::System.EventHandler ObsoleteEvent { add => global::Events.EventHolder.ObsoleteEvent += value; remove => global::Events.EventHolder.ObsoleteEvent -= value; }
"""
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ Scenario: Field with keyworded type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.ConstField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.ConstField"/>
int ConstField { get; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public int ConstField { get => Fields.FieldHolder.ConstField; }
public int ConstField { get => global::Fields.FieldHolder.ConstField; }
"""


Expand All @@ -49,11 +49,11 @@ Scenario: Field with non-keyworded type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.ConstField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.ConstField"/>
double ConstField { get; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public double ConstField { get => Fields.FieldHolder.ConstField; }
public double ConstField { get => global::Fields.FieldHolder.ConstField; }
"""
20 changes: 10 additions & 10 deletions Tests/Tum4ik.StinimGen.Specs/Features/Field/Field.feature
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ Scenario: Non-nullable field with keyworded type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.StaticField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.StaticField"/>
object StaticField { get; set; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public object StaticField { get => Fields.FieldHolder.StaticField; set => Fields.FieldHolder.StaticField = value; }
public object StaticField { get => global::Fields.FieldHolder.StaticField; set => global::Fields.FieldHolder.StaticField = value; }
"""


Expand All @@ -49,13 +49,13 @@ Scenario: Nullable field with keyworded type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.StaticField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.StaticField"/>
object? StaticField { get; set; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public object? StaticField { get => Fields.FieldHolder.StaticField; set => Fields.FieldHolder.StaticField = value; }
public object? StaticField { get => global::Fields.FieldHolder.StaticField; set => global::Fields.FieldHolder.StaticField = value; }
"""


Expand All @@ -68,13 +68,13 @@ Scenario: Non-nullable field
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.StaticField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.StaticField"/>
global::System.Delegate StaticField { get; set; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public global::System.Delegate StaticField { get => Fields.FieldHolder.StaticField; set => Fields.FieldHolder.StaticField = value; }
public global::System.Delegate StaticField { get => global::Fields.FieldHolder.StaticField; set => global::Fields.FieldHolder.StaticField = value; }
"""


Expand All @@ -87,13 +87,13 @@ Scenario: Nullable field
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.StaticField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.StaticField"/>
global::System.Delegate? StaticField { get; set; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public global::System.Delegate? StaticField { get => Fields.FieldHolder.StaticField; set => Fields.FieldHolder.StaticField = value; }
public global::System.Delegate? StaticField { get => global::Fields.FieldHolder.StaticField; set => global::Fields.FieldHolder.StaticField = value; }
"""


Expand All @@ -107,13 +107,13 @@ Scenario: Forward Obsolete attribute
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.ObsoleteField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.ObsoleteField"/>
[global::System.ObsoleteAttribute("Obsolete field")]
object ObsoleteField { get; set; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
[global::System.ObsoleteAttribute("Obsolete field")]
public object ObsoleteField { get => Fields.FieldHolder.ObsoleteField; set => Fields.FieldHolder.ObsoleteField = value; }
public object ObsoleteField { get => global::Fields.FieldHolder.ObsoleteField; set => global::Fields.FieldHolder.ObsoleteField = value; }
"""
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ Scenario: Non-nullable field with keyworded type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.StaticReadonlyField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.StaticReadonlyField"/>
float StaticReadonlyField { get; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public float StaticReadonlyField { get => Fields.FieldHolder.StaticReadonlyField; }
public float StaticReadonlyField { get => global::Fields.FieldHolder.StaticReadonlyField; }
"""


Expand All @@ -49,13 +49,13 @@ Scenario: Nullable field with keyworded type
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.StaticReadonlyField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.StaticReadonlyField"/>
float? StaticReadonlyField { get; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public float? StaticReadonlyField { get => Fields.FieldHolder.StaticReadonlyField; }
public float? StaticReadonlyField { get => global::Fields.FieldHolder.StaticReadonlyField; }
"""


Expand All @@ -68,13 +68,13 @@ Scenario: Non-nullable field
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.StaticReadonlyField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.StaticReadonlyField"/>
global::System.StringComparer StaticReadonlyField { get; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public global::System.StringComparer StaticReadonlyField { get => Fields.FieldHolder.StaticReadonlyField; }
public global::System.StringComparer StaticReadonlyField { get => global::Fields.FieldHolder.StaticReadonlyField; }
"""


Expand All @@ -87,11 +87,11 @@ Scenario: Nullable field
Then there must not be generation exception
And generated interface member must be
"""
/// <inheritdoc cref = "Fields.FieldHolder.StaticReadonlyField"/>
/// <inheritdoc cref = "global::Fields.FieldHolder.StaticReadonlyField"/>
global::System.StringComparer? StaticReadonlyField { get; }
"""
And generated implementation member must be
"""
/// <inheritdoc/>
public global::System.StringComparer? StaticReadonlyField { get => Fields.FieldHolder.StaticReadonlyField; }
public global::System.StringComparer? StaticReadonlyField { get => global::Fields.FieldHolder.StaticReadonlyField; }
"""
Loading

0 comments on commit 04dc773

Please sign in to comment.