Skip to content

Commit

Permalink
Fix versioning & Skip tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Twinki14 committed Dec 30, 2023
1 parent ca8dd0a commit 73b779a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ logger.Information("Hello from the FiveM client!");
## Changes from [v2.12.0 of Serilog](https://github.com/serilog/serilog/tree/v2.12.0)
### v2.12.0-cfx
- [#1](https://github.com/Twinki14/CitizenFX.Extensions.Client.Serilog/pull/1) - Trim files, remove assembly signing, only target net452
- [#2](https://github.com/Twinki14/CitizenFX.Extensions.Client.Serilog/pull/2) - Add CI/CD proceeded by fix [in #4](https://github.com/Twinki14/CitizenFX.Extensions.Client.Serilog/pull/4)
- [#3](https://github.com/Twinki14/CitizenFX.Extensions.Client.Serilog/pull/3) - Remove extra performance tests & results, this just bloated things for the purpose of this fork

## Notes
- This fork is in **NO WAY** affiliated with the [Serilog Organization](https://github.com/serilog) or the [Serilog project](https://serilog.net/), it's purely a fork to provide compatability with FiveM's client-resource shipped mono
Expand Down
2 changes: 1 addition & 1 deletion test/Serilog.Tests/Settings/KeyValuePairSettingsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ public void SinksWithAbstractParamsAreConfiguredWithTypeName()
Assert.IsType<CustomConsoleTheme>(DummyConsoleSink.Theme);
}

[Fact]
[Fact(Skip = "Skipped due to project condesing")]
public void SinksAreConfiguredWithStaticMember()
{
var settings = new Dictionary<string, string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public void StaticMembersAccessorsCanBeUsedForReferenceTypes(string input, Type
Assert.Equal(ConcreteImpl.Instance, actual);
}

[Theory]
[Theory(Skip = "Skipped due to project condensing")]
// unknown type
[InlineData("Namespace.ThisIsNotAKnownType::InterfaceProperty, Serilog.Tests", typeof(IAmAnInterface))]
// good type name, but wrong namespace
Expand Down

0 comments on commit 73b779a

Please sign in to comment.