Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: remove Tyk Gateway as dependency and uses local interface and CertManager #320

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: remove Tyk Gateway as dependency and uses local interface and CertManager #320

wants to merge 1 commit into from

Conversation

mitjaziv
Copy link

@mitjaziv mitjaziv commented Jul 19, 2023 •
edited
Loading

Description

Change removes TykTechnologies/tyk/certs as import and uses locally defined interface.

This change needs expanding of Tyk Gateway/Dashboard certificate manager with
new function ListAny.

Related Issue

TykTechnologies/tyk#5334

Motivation and Context

Idea for this change is to remove Tyk Gateway as dependency from TIB.

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@mitjaziv mitjaziv mentioned this pull request Jul 19, 2023
Open
7 tasks
@mitjaziv mitjaziv force-pushed the fix/use-internal--certs-interface branch 4 times, most recently from 5e4ba6d to b6c0622 Compare July 19, 2023 13:33
@mitjaziv
remove tyk/certs as import and uses local interface
de9bc63 
Change removes TykTechnologies/tyk/certs as import and uses locally
defined interface. This change needs expanding of Tyk Gateway/Dashboard
certificate manager with new function ListAny.
@mitjaziv mitjaziv force-pushed the fix/use-internal--certs-interface branch from b6c0622 to de9bc63 Compare July 19, 2023 13:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mitjaziv