Merge pull request #58 from cdietrich/cd/betterExtensibility

make subclassing MonacoEditorReactComp more easy
TypeFox · Nov 6, 2023 · 781685c · 781685c
2 parents f2f9f95 + 2652f71
commit 781685c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/monaco-editor-react/src/index.tsx b/packages/monaco-editor-react/src/index.tsx
@@ -11,14 +11,14 @@ export type MonacoEditorProps = {
     onLoad?: () => void;
 }
 
-export class MonacoEditorReactComp extends React.Component<MonacoEditorProps> {
+export class MonacoEditorReactComp<T extends MonacoEditorProps = MonacoEditorProps> extends React.Component<T> {
 
     private wrapper: MonacoEditorLanguageClientWrapper = new MonacoEditorLanguageClientWrapper();
     private containerElement?: HTMLDivElement;
     private _subscription: IDisposable | null = null;
     private isStarting?: Promise<void>;
 
-    constructor(props: MonacoEditorProps) {
+    constructor(props: T) {
         super(props);
         this.containerElement = undefined;
     }
@@ -32,7 +32,7 @@ export class MonacoEditorReactComp extends React.Component<MonacoEditorProps> {
         await this.initMonaco();
     }
 
-    override async componentDidUpdate(prevProps: MonacoEditorProps) {
+    override async componentDidUpdate(prevProps: T) {
         const { className, userConfig } = this.props;
         const { wrapper } = this;