Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adam Malcolm's one month submission #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

whatswithadam
Copy link

Pull Request Name / Title

Let us know what added/removed/changed here. Make sure that you have completed the PR Checklist below before you open the PR publicly.

Category

  • One-Month Project Submission
  • Bug Fix

PR Checklist

Complete this checklist before opening your pull request

  • If the PR is a bug fix, the issue is linked in the PR Content
  • If this PR is a One-Month submission, include if you want your site to be listed publicly on our website.
  • If this PR is a work in progress, it's name starts with WIP:. Example: WIP: Nathan Solomon One-Month Submission

Copy link
Contributor

@shorewind shorewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks polished and I like the little animation flairs. A couple typos of "wed" instead of "web". It would be cool to see you expand on this project in the future, filling out the projects and contact pages!

Copy link
Member

@hwittenborn hwittenborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me :). However, I noticed a few issues:

  • Some of the images in assets/ aren't being used.
  • The links in the top-left of the page don't lead to anywhere. I'm not sure if this is intentional or not.

Feel free to add in those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants