Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TMap implementation to lua #755

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add TMap implementation to lua #755

wants to merge 2 commits into from

Conversation

localcc
Copy link
Contributor

@localcc localcc commented Jan 14, 2025

Description

Adds TMap support to lua.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Is/requires documentation update

How Has This Been Tested?

Tested by running a sample project in UE 5.3.2 and calling every function added.

Checklist

Please delete options that are not relevant. Update the list as the PR progresses.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added the necessary description of this PR to the changelog, and I have followed the same format as other entries.
  • Any dependent changes have been merged and published in downstream modules.

@localcc localcc marked this pull request as ready for review January 14, 2025 17:02
Copy link
Contributor

github-actions bot commented Jan 14, 2025

MSVC-Game__Debug__Win64 Download Logs
Build Details
Name Information
PR Commit 8a0a43b
Merge Commit d34e9b8
Size 47.04 MB
Last Updated Jan 17, 25, 6:04:32 PM UTC
Expires At Jan 31, 25, 6:04:27 PM UTC

MSVC-Game__Shipping__Win64 Download Logs
Build Details
Name Information
PR Commit 8a0a43b
Merge Commit d34e9b8
Size 28.54 MB
Last Updated Jan 17, 25, 6:09:46 PM UTC
Expires At Jan 31, 25, 6:09:43 PM UTC

UE4SS/src/LuaType/LuaTMap.cpp Show resolved Hide resolved
UE4SS/src/LuaType/LuaTMap.cpp Outdated Show resolved Hide resolved
UE4SS/src/LuaType/LuaTMap.cpp Outdated Show resolved Hide resolved
UE4SS/src/LuaType/LuaTMap.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@UE4SS UE4SS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.
I haven't tested it.

@UE4SS
Copy link
Collaborator

UE4SS commented Jan 20, 2025

Status: We've had several people successfully test this PR in the discord server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants