-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TADA_DataRetrieval updates for sf option, tribal options, big data options #566
Open
mbrousil
wants to merge
40
commits into
USEPA:develop
Choose a base branch
from
rossyndicate:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Katie/Ryn Willi (she/her) <[email protected]>
Add sf, big data to TADA_DataRetrieval
Co-authored-by: B Steele <[email protected]>
Co-authored-by: B Steele <[email protected]>
Co-authored-by: B Steele <[email protected]>
Prepare for submission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR covers a few large changes to the data retrieval process based on conversations I have had with Cristina and Hillary:
Overview
Additional info
TRIBE_NAME
orPARCEL_NO
entries from that layer. The TADA_TribalOptions function is included to help users seeTRIBE_NAME
/PARCEL_NO
options available to them and check punctuation, etc.A few notes:
NULL
as the default for the aoi_sf argument instead of"null"
because the character version didn't work properlyPlease let me know if I can provide any other info on any of this! For example I didn't include any info from speed tests to avoid overwhelming amounts of info here. Thanks for your help.
Closes #361, closes #427, closes #345, closes #159