API Documentation Edits to wntr/network/model.py #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changed to “str”
…er add_pipe changed to “str”
…meter, pattern, & initial_status under add_pump changed to “str”
…hanged to “str” and “pattern” linked under parameter pattern
…prefix changed to “str” under assign_demand
…setting, and Initial_status under add_value changed to “str”
…r than “geopandas.GeoDataFrame” until intersphinx_mapping in documentation/conf.py is updated with geopandas
…k pandas.Series & WaterNetworkModel linked & attempting to link to_graph
…olated_junctions_and_links
…olated_junctions_and_links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a summary of the proposed changes, describe tests and documentation, and review the acknowledgement below.
Summary
This pull request addresses an update to the API documentation in the wntr/network/model.py file to enhance usability and clarity for users. Key changes include updating parameter types from “string” to “str” and “dictionary” to “dict” to provide a direct link to Python documentation. Additionally, the documentation was changed to add direct links for relevant Pandas, Numpy, and WNTR classes and modules.
Tests and documentation
This change impacts only the documentation and does not modify the functionality of the code. Therefore, no additional tests are required.
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.