-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building and testing issues #467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kbonney
changed the title
Update manifest to include new binaries
Fix building and testing issues
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several issues with the building and testing process for WNTR:
wntr 1.3.0 wheels do not include the epanet binaries. This is the cause of Colab problem #466.
during the install_import step of the build job, only a basic
import wntr
test is run on the installed wheel. This causes us to miss deeper problems with the wheel such as the missing binaries mentioned above.The wheel for macos-13 is saved with the wrong name (references macos version 14.0 instead of 13.0) and cannot be found when installing from wheels on that OS.
Plotly introduced breaking changes in the latest major version (6.0.0) which affect plot_interactive_network and causes tests to fail. I believe this is the relevant change: Drop support for passing a string to the
title
attribute, and drop support for deprecated attributestitlefont
,titleposition
,titleside
, andtitleoffset
plotly/plotly.js#7212.Tests and documentation
n/a
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.