Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to support BEA 2017 Schema data release #280

Merged
merged 88 commits into from
Mar 19, 2024
Merged

Updates to support BEA 2017 Schema data release #280

merged 88 commits into from
Mar 19, 2024

Conversation

bl-young
Copy link
Collaborator

@bl-young bl-young commented Feb 28, 2024 •
edited
Loading

  • Adds data objects for 2017 schema using new schema suffix: _17sch
    • 2017 Detail tables (Make, Use, Supply, Use_SUT)
    • 2017-2022 Summary tables
    • 2017 MasterCrosswalk
    • 2012 schema objects renamed with _12sch
  • Drops support for building sector level models
  • Adjusts downloading of BEA data to store objects within local/USEEIO-Input folder
  • Implemented warning if sectors in TbS do not align with model schema (e.g., TbS w/ 2012 NAICS which does not align with the model crosswalk); this could be updated to allow for more NAICS mapping within the satellite table in the future.
  • Adds test for detail and summary model w/ 2017 schema (v3.0)

WesIngwersen and others added 30 commits October 12, 2023 09:23
@WesIngwersen
Add 2017 detail supply use tables as rdata with json metadata; modify…
e02d979 
… data read function names to remove 2012schema or 2012 as they function without that to grab newest data
@WesIngwersen
Update getBEACodeName to get names from SUT Use table -- only detail …
b8e2823 
…done.. Summary and sector TBD
@WesIngwersen
source file
546236e
@bl-young
reference latest NAICS crosswalk table, consolidate download code
92defbc
@bl-young
initiate master crosswalk 2017
6f0f17c
@bl-young
Merge branch '2017SUT' of https://github.com/USEPA/useeior into 2017SUT
f03fda2
@bl-young
add initial copies of pre-created tables, copied from 2012 files with…
3b7ea4f 
… column names updated
@bl-young
fix missing variable
9214d56
@bl-young
fix error with extra columns from 2017 NAICS file
7e1f8e6
@bl-young
add draft MasterCrosswalk2017.rda
b9b32cd
@bl-young
update documentation
6d0f88d
@WesIngwersen
Update summary Supply and Use tables 2017-2022
3543748
@WesIngwersen
Merge branch '2017SUT' of https://github.com/USEPA/useeior into 2017SUT
a89af7c
@WesIngwersen
Simplify MasterCrosswalk.R. Only work for one year but include data o…
8c84890 
…bject with multiple data years
@WesIngwersen
add Detail import 2017; update code
07bc60c
@bl-young
Merge branch 'master' into 2017SUT
fa4227f
@bl-young
add missing documentation for data objects
08d496f
@bl-young
add documentation objects
7d72a1d
@bl-young
Merge branch '2017SUT' into 2017MakeUse
10fb430 
# Conflicts:
#	data-raw/BEAData_Detail.R
@bl-young
initial consolidation of detail functions; store underlying raw BEA d…
cc91a02 
…ata in appdirs `USEEIO-input`
@bl-young
update accessing summary tables
8251bc8
@bl-young
update getBEAUnderlyingTables()
03dc421
@bl-young
update getSummaryUsePURBeforeRedef()
a9b9f5f
@bl-young
add schema year to file name
8d9d381
@bl-young
fix error in BEADetailMakeAfterRedef
d24cab1
@bl-young
fix typo
d4d36c7
@bl-young
use appdirs for imports excel file
00af100
@bl-young
update getBEACodesNames()
5128260
@bl-young
update dir in SUT tables
4b026fc
@bl-young
update get BEADetailMargins()
35a0e35
@bl-young bl-young marked this pull request as ready for review February 28, 2024 21:56
@bl-young
Copy link
Collaborator Author

ok @WesIngwersen I think this should be ready to go.

@WesIngwersen
Copy link
Collaborator

Please check that the Sector level IO tables are never loaded for a supporting purpose

@WesIngwersen
Copy link
Collaborator

WesIngwersen commented Mar 6, 2024 •
edited
Loading

I see one modelspec updated - the 2.1 model. Let's not use that specfor 2.1.. That should be a 3.0.

@bl-young
Copy link
Collaborator Author

bl-young commented Mar 6, 2024

I see one modelspec updated - the 2.1 model. Let's not use that specfor 2.1.. That should be a 3.0.

Yes I didn't have a great handle for how we wanted to handle the naming schema for models using 2017 IO schema. I can change it to 3.0

@bl-young
Copy link
Collaborator Author

Please check that the Sector level IO tables are never loaded for a supporting purpose

I am not seeing any.

I see one modelspec updated - the 2.1 model. Let's not use that specfor 2.1.. That should be a 3.0.

Ok this is done.

@bl-young
Copy link
Collaborator Author

new errors in testing arising only on mac seem to be associated with the new release of arrow 15.0.1 (was passing under 14.0.0.2)

@bl-young bl-young merged commit 4317133 into develop Mar 19, 2024
6 of 8 checks passed
@bl-young bl-young deleted the 2017MakeUse branch March 19, 2024 03:31
@bl-young bl-young mentioned this pull request Mar 22, 2024
Merged
@bl-young bl-young mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WesIngwersen WesIngwersen Awaiting requested review from WesIngwersen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bl-young @WesIngwersen