Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-11255] improve engine logging #1977

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

wawanbreton
Copy link
Contributor

@wawanbreton wawanbreton commented Nov 3, 2023

Content of modifications :

  • Use spdlog::stopwatch instead of custom time functions to measure time (which fixes wrong timing reports, at least on Linux)
  • Make timing report consistent and more readable:
[2023-11-03 11:48:47.158] [info] Progress: inset+skin accomplished in 2.4762119999998s
===>
[2023-11-03 11:48:47.158] [info] Progress: inset+skin accomplished in 2.476s
  • Add timing report for layer export processing, which is usually the longest step. Only the steps reported longer than 10ms (configurable by code) are displayed, and only the layers reported longer than 100 ms are fully displayed:
[2023-11-07 10:45:40.073] [info] ┌ Layer export [244] accomplished in 0.139s
[2023-11-07 10:45:40.073] [info] ├── Init:   0.012s
[2023-11-07 10:45:40.073] [info] └── Mesh 0: 0.119s
[2023-11-07 10:45:40.076] [info] Skipped time reporting for layers [245...246]
[2023-11-07 10:45:40.076] [info] ┌ Layer export [246] accomplished in 0.113s
[2023-11-07 10:45:40.076] [info] └── Mesh 0: 0.109s
[2023-11-07 10:45:40.088] [info] ┌ Layer export [247] accomplished in 0.110s
[2023-11-07 10:45:40.088] [info] └── Mesh 0: 0.104s
[2023-11-07 10:45:40.090] [info] ┌ Layer export [248] accomplished in 0.108s
[2023-11-07 10:45:40.090] [info] └── Mesh 0: 0.102s
[2023-11-07 10:45:40.395] [info] Skipped time reporting for layers [249...309]
[2023-11-07 10:45:40.395] [info] ┌ Layer export [309] accomplished in 0.109s
[2023-11-07 10:45:40.395] [info] └── Mesh 0: 0.106s

The last added logging make it very easy to see when something is wrong during the export step, although it does get into the deep details.

@wawanbreton wawanbreton changed the base branch from main to 5.6 November 3, 2023 10:59
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Unit Test Results

26 tests  ±0   26 ✔️ +1   15s ⏱️ +3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0  - 1 

Results for commit c07a0a1. ± Comparison against base commit a58cb53.

♻️ This comment has been updated with latest results.

@nallath nallath merged commit 3002b3b into 5.6 Nov 7, 2023
17 checks passed
@nallath nallath deleted the CURA-11255_improve-engine-logging branch November 7, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants