Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add z height to CuraEngine Infill Plugin Call #2132

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

EmJay276
Copy link
Contributor

@EmJay276 EmJay276 commented Aug 7, 2024

Description

This adds the z-height of the current layer to the settings of the CureEngine Infill plugins.
This does NOT break compatibility with existing plugins.

Type of change

  • New feature (non-breaking change which adds functionality)

Added z-height to the settings dict passed to the CureEngine Infill Plugin.
This was necessary to ensure compatibility with existing plugins.

How Has This Been Tested?

Test Configuration:

  • Operating System: Windows 10

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Aug 7, 2024
@EmJay276
Copy link
Contributor Author

EmJay276 commented Aug 7, 2024

I don't know why the conan-package / conan-package-export / package-export (pull_request) test fails.
In unit-test / testing / testing (pull_request) everything seams to build properly.

@EmJay276
Copy link
Contributor Author

EmJay276 commented Aug 8, 2024

Here are some additional screenshots of the new functionality enabled for Engine Plugins

@rburema
Copy link
Member

rburema commented Sep 4, 2024

Devs: Added internal ticket CURA-12132 to track progress of this PR.

@wawanbreton
Copy link
Contributor

Hi @EmJay276, we were actually working on a similar topic on our side, so your changes have been manually integrated to #2137. Can you please check that we didn't forget anything, and then close this PR ?

@EmJay276
Copy link
Contributor Author

@wawanbreton #2137 seems good to me!
I will close this PR after #2137 is merged

@HellAholic HellAholic merged commit 4fdee03 into Ultimaker:main Oct 4, 2024
20 of 21 checks passed
@EmJay276 EmJay276 deleted the PR_plugin_z_height branch November 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants