Change segment overhanging calculation formula #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12078 Instead of naively checking whether the start and end point of the segment are in the overhang area, calculate the intersection of the segment with the overhang area, and see if the length of the intersection is a significant enough part of the origin segment. This filters out some segments that partially overhang and are not really expected to be treated as overhanging.
…nt-wall-speed-besides-overhang
rburema
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Made a PR to adjust the description of Overhanging Wall Angle to clarify the new behaviour here: Ultimaker/Cura#19725
HellAholic
deleted the
CURA-12078_inconsistent-wall-speed-besides-overhang
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-12078
Instead of naively checking whether the start and end point of the segment are in the overhang area, calculate the intersection of the segment with the overhang area, and see if the length of the intersection is a significant enough part of the origin segment. This filters out some segments that partially overhang and are not really expected to be treated as overhanging.
The behavior is technically a bit less correct than the former one, but tends to more homogeneity in the speeds so it may be preferable overall.
This is quite experimental, but did perform very well on all the models I tested. Please test it more extensively, there may be edge cases that I overlooked.