Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent implicit unsigned to signed conversions #2149

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Prevent implicit unsigned to signed conversions #2149

merged 1 commit into from
Oct 18, 2024

Conversation

casperlamboo
Copy link
Contributor

@casperlamboo casperlamboo commented Oct 17, 2024 •
edited
Loading

Description

This PR builds on top of #2139 as we found a few more cases where this goes wrong.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Yes

Test Configuration:

  • Operating System: Mac OS/emscripten

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

Issue originally found by @ToyboxZach in his comment

NP-448

wawanbreton
wawanbreton approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I hope they are the last ones

@HellAholic HellAholic merged commit dabbdac into 5.9 Oct 18, 2024
29 checks passed
@HellAholic HellAholic deleted the NP-448 branch October 18, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawanbreton wawanbreton wawanbreton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casperlamboo @wawanbreton @HellAholic