CURA-12265 the wiping movement goes in the wrong direction #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12265 Previously, there were two different implementations of the same feature, for Polygons and ExtrusionLines. We now have a single method to handle this for the two types, avoiding different behaviors.
CURA-12265 With the addition of the scarf seam, printing an extrusion line now may end at a different position that the last point on the line, so the wipe travel should start at this position.
…oes-in-the-wrong-direction' into CURA-12265_the-wiping-movement-goes-in-the-wrong-direction
rburema
reviewed
Nov 8, 2024
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: f94839a | Previous: 2ba2e24 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_slot_noplugin |
3.7147266889434327 ns/iter |
1.8573234523479047 ns/iter |
2.00 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
nallath
approved these changes
Nov 11, 2024
HellAholic
deleted the
CURA-12265_the-wiping-movement-goes-in-the-wrong-direction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wiping movement while adding extrusion lines didn't care of the reversed order. We now use a common method while adding either Polygons and ExtrusionLines, which takes care of the reversion.
Also fixes the wipe movement interaction with the scarf seam by taking the actual last printed point, which can now be different from the path last point due to the scarf seam closure.
CURA-12265
CURA-12266