Add worklfows for building npm package for curaengine #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellespijker
approved these changes
Nov 27, 2024
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| branch: |
There was a problem hiding this comment.
instead of branch I would have conan id: curaengine/5.9.0@_/_ or curaengine/latest@testing/main
| packages: write | ||
|
|
||
| steps: | ||
| - name: Checkout code |
There was a problem hiding this comment.
No need to check out if you use the conan version ⬆️
| - name: Get Conan configuration | ||
| run: | | ||
| conan config install https://github.com/Ultimaker/conan-config.git | ||
| conan config install https://github.com/Ultimaker/conan-config.git -a "-b NP-419" |
There was a problem hiding this comment.
This should use the conan config install https://github.com/Ultimaker/conan-config.git -a "-b runner/${{ runner.os }}/${{ runner.arch }}" now.
Otherwise you end up using your experimental emsdk versions
| "description": "CuraEngineJS a TS component to run CuraEngine in a browser", | ||
| "main": "src/CuraEngine.js", | ||
| "scripts": { | ||
| "install_curaengine": "conan install ${npm_package_config_conan_package} -s build_type=Release --build=missing --update -c tools.build:skip_test=True -pr:h cura_wasm.jinja -if src && rm -f src/*conan*", |
There was a problem hiding this comment.
Do the install script now in the package.json but in the workflow and use the conan version id ⬆️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NP-549