Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for up to #VERSION:1.2.0. #52

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

bohning
Copy link
Collaborator

@bohning bohning commented Jan 8, 2025

This adds support for the newly introduced tags (#VERSION, #AUDIO, #VOCALS, #INSTRUMENTAL, #AUDIOURL, #COVERURL and #BACKGROUNDURL). These tags are read and written, but so far no conversion between the different version is implemented.

This adds support for the newly introduced tags (#VERSION, #AUDIO, #VOCALS, #INSTRUMENTAL, #AUDIOURL, #COVERURL and #BACKGROUNDURL). These tags are read and written, but so far no conversion between the different version is implemented.
@bohning bohning requested a review from DeinAlptraum January 8, 2025 20:49
Copy link
Collaborator

@DeinAlptraum DeinAlptraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since entire sections may be missing depending on the format version, it might be worth considering hiding them entirely, e.g. URLs, when the format version is too low. But that can happen in another PR either way.

@bohning bohning merged commit cb28847 into master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants