add quote view fn & replace getCompactWitnessTypestring w/ getCompactWitnessDetails #3
Conversation
| return _Router_quoteDispatch( | ||
| claimChain, | ||
| Message.encode(compact, allocatorSignature, sponsorSignature, hash(intent), intent.fee, filler), | ||
| "", |
There was a problem hiding this comment.
if we dont populate anything here, the handle function is assumed to have a gas limit of 50k
we may need to adjust this, have you successfully used these quotes in prod yet?
There was a problem hiding this comment.
not yet — open question on whether to just build in an approximate buffer and let filler work out the exact quoted fee or if the UI should derive it locally
| compactTokenArguments = new string[](1); | ||
| compactTokenArguments[0] = "fee"; | ||
|
|
||
| // Arguments that refer to some amount of an arbitrary chain + token combination | ||
| customTokenArguments = new string[3][](1); | ||
| customTokenArguments[0] = ["intent.chainId", "intent.token", "intent.amount"]; |
There was a problem hiding this comment.
would be very happy to just adopt whatever standard struct you propose on the compact
this would facilitate both users and fillers to understand the eip712 payloads better
There was a problem hiding this comment.
I do feel like some form of JSON payload that lays out the typestring as well as the various semantic context and relations between the arguments could be a better way than .. whatever this is 🤣
that said, it does get the job done for just detecting token names / decimals to use 🤷
No description provided.