revert steth #331
Merged
revert steth #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marktoda
commented
Nov 9, 2023
marktoda
commented
- Revert "add (un)/wrapping for steth (add (un)/wrapping for steth #317)"
- Revert "deploy UniversalRouter v1.3 to mainnet and goerli (deploy UniversalRouter v1.3 to mainnet and goerli #320)"
- fix: fixup steth leftovers
zhongeric
approved these changes
Nov 15, 2023
README.md
Outdated
| @@ -251,7 +237,7 @@ forge script --broadcast \ | |||
| --rpc-url <RPC-URL> \ | |||
| --private-key <PRIVATE-KEY> \ | |||
| --sig 'run()' \ | |||
| script/deployParameters/Deploy<network>.s.sol:Deploy<network> \ | |||
| script/deployParameters/Deploy<network>.s.sol:Deploy<network> | |||
hensha256
reviewed
Nov 16, 2023
README.md
Outdated
| @@ -234,7 +230,7 @@ yarn test:gas | |||
|
|
|||
| ### To Deploy | |||
|
|
|||
| Fill out parameters in `script/deployParameters/Deploy<network>.s.sol` | |||
| Fill out parameters in `script/deployParameters/Deploy<network>.s.sol` \ | |||
hensha256
reviewed
Nov 16, 2023
README.md
Outdated
| │ 0x24 │ UNWRAP_STETH │ | ||
| ├──────┼───────────────────────────────┤ | ||
| │ 0x25-│ ------- │ | ||
| │ 0x1e-│ ------- │ |
There was a problem hiding this comment.
why 1e? Shouldnt it be 0x23?
hensha256
reviewed
Nov 16, 2023
hensha256
approved these changes
Jan 3, 2024
zhongeric
approved these changes
Jan 3, 2024
BowTiedDevil
added a commit
to BowTiedDevil/degenbot
that referenced
this pull request
Feb 13, 2024
Reverted in master ref: Uniswap/universal-router#331
|
Hello, is it possible to know why you decided to stop supporting wrapping stETh/ unwrapping wstETH ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.