feat: make fee collector open and competitive #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
force-pushed
the
competitive-fee-collector
branch
from
05d7e48 to
8c726da
Compare
New fee collector implementation where anyone can make any calls from the collector in return for a specific amount of the fee token. Searchers can then compete to execute based on the current balance of tokens and the best route
marktoda
force-pushed
the
competitive-fee-collector
branch
from
8c726da to
4409111
Compare
|
currently this is like $XYZ for the sum balance of all tokens on the fee collector |
marktoda
force-pushed
the
competitive-fee-collector
branch
from
9c7e13d to
421cf9b
Compare
snreynolds
reviewed
May 9, 2024
| /// @dev as long as they pay `feeTokenAmount` per token taken to the `feeRecipient` | ||
| /// this creates a competitive auction as the balances of this contract increase | ||
| /// to find the optimal path for the swap | ||
| function swapBalances(ERC20[] memory tokens, bytes calldata call) external { |
There was a problem hiding this comment.
seems unnecessary to pass through this call info, why not just have a shared interface for the callback?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New fee collector implementation where anyone can make any calls from
the collector in return for a specific amount of the fee token.
Searchers can then compete to execute based on the current balance of
tokens and the best route