Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE: Update pull request template #1950

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

stefanunity
Copy link
Collaborator

Description

See title

Changes made

removed outdated info, added Testing & Risk section.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@stefanunity stefanunity changed the title Update pull_request_template.md CAHNGE: Update pull_request_template.md Jun 20, 2024
@stefanunity stefanunity changed the title CAHNGE: Update pull_request_template.md CHANGE: Update pull_request_template.md Jun 20, 2024
@stefanunity stefanunity changed the title CHANGE: Update pull_request_template.md CHANGE: Update pull request template Jun 20, 2024
@stefanunity stefanunity merged commit f228c14 into develop Jun 20, 2024
78 of 82 checks passed
@stefanunity stefanunity deleted the input/update-pr-template branch June 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant