Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Submit and Cancel actions should obey configured interactions. #1956

Merged

Conversation

smnwttbr
Copy link
Collaborator

@smnwttbr smnwttbr commented Jun 25, 2024

Description

Submit and Cancel actions were always triggered on a press event, even if the interaction was configured as ReleaseOnly. This PR changes that so that Interactions are respected. ISXB-841

Changes made

InputSystemUIInputModule was changed to use WasPerformedThisFrame() instead of WasPressedThisFrame().

Testing

Tested manually using project supplied in Jira.

Risk

These changes are fundamental to how the submit and cancel actions are triggered. Any projects relying on the old behaviour will be disrupted.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@smnwttbr smnwttbr changed the title Submit and Cancel actions should obey configured interactions. CHANGE: Submit and Cancel actions should obey configured interactions. Jun 25, 2024
@smnwttbr smnwttbr marked this pull request as ready for review June 25, 2024 08:30
@smnwttbr smnwttbr requested a review from ekcoh June 25, 2024 08:31
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, suggest just getting a sanity check from @benoitalain or @bmalrat on this one in case of side effects. Would be awesome if it could be covered by an automated test as well (if not already covered by a test in UITests.cs).

@ekcoh ekcoh requested a review from stefanunity June 25, 2024 10:10
@ekcoh
Copy link
Collaborator

ekcoh commented Jun 25, 2024

Added @stefanunity for QA assessment.

@bmalrat
Copy link
Collaborator

bmalrat commented Jun 25, 2024

Changes look good to me, suggest just getting a sanity check from @benoitalain or @bmalrat on this one in case of side effects. Would be awesome if it could be covered by an automated test as well (if not already covered by a test in UITests.cs).

Seems good for me, I don't see any side effects for that one

@ekcoh
Copy link
Collaborator

ekcoh commented Jun 28, 2024

@smnwttbr I only believe conflicts need to be resolved and then I think you may merge this.

@ekcoh
Copy link
Collaborator

ekcoh commented Jun 28, 2024

I fixed the conflict in CHANGELOG.md and also moved the message from CHANGE to FIX since this was a bug report and behavior didn't do what it was supposed to. Let me know if you think it was an incorrect call.

@smnwttbr smnwttbr changed the title CHANGE: Submit and Cancel actions should obey configured interactions. FIX: Submit and Cancel actions should obey configured interactions. Jul 1, 2024
@smnwttbr smnwttbr merged commit 34d2cca into develop Jul 1, 2024
77 of 80 checks passed
@smnwttbr smnwttbr deleted the isxb-841-submit-and-cancel-should-obey-interactions branch July 1, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants