-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: tree state in treeview should be preserved when saving (ISXB-966) #1967
Conversation
@smnwttbr will take a look at this today. At first sight though there seems to be a lot of CI failures, have you looked into those yet? Fine for me to test or are you planning some revisions? |
InstanceID was being used for the viewDataKey, which changes on domain reloads. |
Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ActionsTreeView.cs
Outdated
Show resolved
Hide resolved
https://github.com/user-attachments/assets/4af90b49-786b-48db-986d-4aae0bc3b5cf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but if the thing above is not expected and you rework it then re-request my review
Description
When the input action asset is saved, the selection state of the trees in the editor will occasionally be reset.
Changes made
The TreeStateView has now been setup correctly.
Testing
Manual testing only.
Risk
Risk is 0.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: