Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: tree state in treeview should be preserved when saving (ISXB-966) #1967

Merged
merged 13 commits into from
Aug 19, 2024

Conversation

smnwttbr
Copy link
Collaborator

Description

When the input action asset is saved, the selection state of the trees in the editor will occasionally be reset.

Changes made

The TreeStateView has now been setup correctly.

Testing

Manual testing only.

Risk

Risk is 0.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@smnwttbr smnwttbr requested a review from Pauliusd01 July 18, 2024 04:02
@smnwttbr smnwttbr marked this pull request as draft July 18, 2024 08:37
@Pauliusd01
Copy link
Collaborator

@smnwttbr will take a look at this today. At first sight though there seems to be a lot of CI failures, have you looked into those yet? Fine for me to test or are you planning some revisions?

@smnwttbr smnwttbr marked this pull request as ready for review July 30, 2024 03:45
@smnwttbr smnwttbr requested a review from jfreire-unity July 30, 2024 03:46
@smnwttbr
Copy link
Collaborator Author

InstanceID was being used for the viewDataKey, which changes on domain reloads.

@Pauliusd01 Pauliusd01 changed the title FIX: selection state in treeview should be preserved when saving FIX: selection state in treeview should be preserved when saving (ISXB-966) Aug 1, 2024
@Pauliusd01
Copy link
Collaborator

https://github.com/user-attachments/assets/4af90b49-786b-48db-986d-4aae0bc3b5cf
On heavier, domain reload prone projects (like the one in the alternative steps) the selection is still reset but the expansions are maintained so it is still a noticeable improvement. Just making sure this is expected? I'm fine with approving as I did not notice any issues

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but if the thing above is not expected and you rework it then re-request my review

@smnwttbr smnwttbr self-assigned this Aug 12, 2024
@smnwttbr smnwttbr changed the title FIX: selection state in treeview should be preserved when saving (ISXB-966) FIX: tree state in treeview should be preserved when saving (ISXB-966) Aug 12, 2024
@smnwttbr smnwttbr added this to the 1.3.0 milestone Aug 12, 2024
@Pauliusd01 Pauliusd01 self-requested a review August 13, 2024 08:57
@smnwttbr smnwttbr merged commit 730bb23 into develop Aug 19, 2024
77 of 79 checks passed
@smnwttbr smnwttbr deleted the isx-1980-fix-selection-state-in-treeview branch August 19, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants