FIX: Input System 1.9.0 does not compile on Console Platforms (ISXB-963) #1971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix build issues on console platforms that do not support analytics.
Changes made
Guards code with
ENABLE_CLOUD_SERVICES_ANALYTICS
which was raising compilation errors on console platforms.From documentation:
Possible there's some things we can do to improve our
UNITY_ANALYTICS
defines vsENABLE_CLOUD_SERVICES_ANALYTICS
use. I raised the question on what's the difference between them. cc @ekcoh for further discussions.For now, this will likely unblock the console platform but we should revisit this in the future IMO. Raised task here
Testing
I tested data data was sent from the macOS editor and that there apparently there's no regression in the data that is being sent. But maybe @ekcoh can validate 100% once he's back from vacation. @Pauliusd01 if you can check that there's no regression in the data sent to the backend, that would be great (I mentioning you because you approved the PR with analytics #1808 ).
Also validated that at least one console platform the build error was fixed. @lewish-unity please make sure this branch fixes the error you reported.
Risk
I validated that the Editor analytics were sent with Unity 6, but couldn't validate with 2022.3f as the analytics debugger is not available for that version.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: