Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Input System 1.9.0 does not compile on Console Platforms (ISXB-963) #1971

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

jfreire-unity
Copy link
Collaborator

@jfreire-unity jfreire-unity commented Jul 23, 2024

Description

Fix build issues on console platforms that do not support analytics.

Changes made

Guards code with ENABLE_CLOUD_SERVICES_ANALYTICS which was raising compilation errors on console platforms.

From documentation:

Important: Always make calls to the Analytics API inside the scope of an #if ENABLE_CLOUD_SERVICES_ANALYTICS statement to prevent compilation errors on platforms that do not support Analytics:

Possible there's some things we can do to improve our UNITY_ANALYTICS defines vs ENABLE_CLOUD_SERVICES_ANALYTICS use. I raised the question on what's the difference between them. cc @ekcoh for further discussions.

For now, this will likely unblock the console platform but we should revisit this in the future IMO. Raised task here

Testing

I tested data data was sent from the macOS editor and that there apparently there's no regression in the data that is being sent. But maybe @ekcoh can validate 100% once he's back from vacation. @Pauliusd01 if you can check that there's no regression in the data sent to the backend, that would be great (I mentioning you because you approved the PR with analytics #1808 ).

Also validated that at least one console platform the build error was fixed. @lewish-unity please make sure this branch fixes the error you reported.

Risk

I validated that the Editor analytics were sent with Unity 6, but couldn't validate with 2022.3f as the analytics debugger is not available for that version.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

Console platforms don't have this module so this code would break.
Copy link
Collaborator

@lewish-unity lewish-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on affected platforms and the error no longer appears. Can create a build successfully with this version installed.
CI is passing.

@jfreire-unity jfreire-unity merged commit 0c1b0f0 into develop Jul 24, 2024
75 of 78 checks passed
@jfreire-unity jfreire-unity deleted the isx-963-fix-analytics-on-consoles branch July 24, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants