FIX: ISXB-953 InputSystemProvider GC Alloc #1973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira ticket: https://jira.unity3d.com/browse/ISXB-953
Fixes memory allocated every frame when using InputForUI with InputSystem package, i.e. when using a UIDocument without an EventSystem.
Changes made
InputForUITests.Update_DoesntAllocate
that fails without the fix and passes with it.Testing
Manually tested the repro project profiler evidence, and the fix. Added a unit test.
Risk
Very low risk. Change is a one-liner, simple and only has a local impact.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: