-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: add code coverage to CI jobs running Editor and Playmode tests on editor platforms #2086
Conversation
This reverts commit 0b6664b.
@stefanunity I unzipped "artefacts" in Yamato on this PR but could find any coverage report there, where may I find it? |
@stefanunity Maybe its only on specific jobs? You mention integration tests (not many tests) and project tests? |
See DM with artifact links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to get this added. Thank you.
Thanks for helping find the coverage report jobs @stefanunity. Fist of all, great to get this added. However, when reviewing the generated report, e.g. looking at HTML report https://yamato-artifactviewer.prd.cds.internal.unity3d.com/a62e0ec1-0e59-4934-b3f4-b15136f269d1%2FUTR_Output.zip%2Fupm-ci~%2Ftest-results%2FCodeCoverage%2FPackage%2FReport/index.html (Win job), I notice code coverage is extremely low. Picking a certain random class, e.g. GamepadState, we can see that code coverage is 0% in the report, another example I checked was PressedInteraction which also report 0% coverage. Putting a breakpoint inside these classes and running the test suite in editor locally hits those method from the test suite so something is wrong. (Play mode tests) I suspect, maybe a merge operation of cobertura reports isn't done to get a merged report before calling report tool? And the current result we see is likely only editor tests? Since there are multiple test runs their results should be merged. It might be that coverage is only indicating a partial runs results? |
Looking at the artefacts there seem to be 4 xml reports that need to be merged before generating report with ReportTool unless it support multiple sources on CLI interface. |
Resolved as per convo in sync meeting. |
Description
Testing status & QA
Overall Product Risks
No product risk, test jobs take slightly more time.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: