-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Throw error when extension for inputsystem needed #2101
NEW: Throw error when extension for inputsystem needed #2101
Conversation
…github.com/Unity-Technologies/InputSystem into throw-error-nda-inputsystem-without-plugin
Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPluginControl.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPluginControl.cs
Show resolved
Hide resolved
|
Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPluginControl.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM here's a list of things I checked:
Opening a project with the platform already pre-selected - works as expected, error shows up
Switch to windows from a console platform - no error, as expected
Built on Xbox series x without the extension package - no error, but seems to be expected
Custom build profiles (with a console platform included) - error shows up without the extension as expected, cleared with the extension as expected
Xbox series X profile and Xbox extension installed - errors stop showing up as expected
Xbox profile and incorrect extension installed - still get the error as expected
I repeated the above with PS4, PS5 & Switch with only their Editor extensions built (It just means I can I use the platform in Editor as normal but cannot build the player. So keep in mind that these platform players were not built) and had the same expected results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates
Description
Trying to use Input System package on console without the NDA package installed outputs an error message to the user.
The error is thrown in [OnInitializeLoad] and performs on loading a project, on switching platforms and domain reload.
Link to the related ticket.
GXDK extension registeres it self with this PR.
Testing status & QA
Manual testing for Switch platform.
Platforms missing: (which should surface this error without the installed Plugin)
-gamecore
-playstation (4&5)
-switch
-xboxone
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: