Skip to content

Commit

Permalink
fix: remove v prefix from reported sdk version
Browse files Browse the repository at this point in the history
  • Loading branch information
Tymek committed Jan 29, 2025
1 parent fc6b3f4 commit 82babf0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Unleash/UnleashSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ private static string GetSdkVersion()
var assemblyName = Assembly.GetExecutingAssembly().GetName();
var version = assemblyName.Version.ToString(3);

return $"unleash-client-dotnet:v{version}";
return $"unleash-client-dotnet:{version}";
}

private static string GetDefaultInstanceTag()
Expand Down
3 changes: 2 additions & 1 deletion tests/Unleash.Tests/UnleashSettingsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ public void Should_set_sdk_name()
var settings = new UnleashSettings();

// Assert
settings.SdkVersion.Should().StartWith("unleash-client-dotnet:v");
settings.SdkVersion.Should().StartWith("unleash-client-dotnet:");
settings.SdkVersion.Should().MatchRegex(@":\d+\.\d+\.\d+");
}
}
}

0 comments on commit 82babf0

Please sign in to comment.