Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nuke path-util #842

Merged
merged 6 commits into from
Jan 29, 2025
Merged

fix: Nuke path-util #842

merged 6 commits into from
Jan 29, 2025

Conversation

SaadBazaz
Copy link
Collaborator

@SaadBazaz SaadBazaz commented Jan 8, 2025

Issue in installing usdk, path-util not found. Path-util seems like a workaround in order to get imports to work in NextJS. Removing it, will have to split cli.js later.

This is just the first step, I'm breaking my approach into multiple PRs so that we can debug step-by-step. This may break docs build.

  • Nuke this path-utils file
  • Rewrite/split packages/usdk/cli.js so it creates the program WITHOUT importing the codecs (DO LATER)
  • Update docs code (DO LATER)

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 3:09pm
upstreet.ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 3:09pm

@mavisakalyan mavisakalyan merged commit 141eb60 into dev Jan 29, 2025
4 checks passed
@mavisakalyan mavisakalyan deleted the nuke-path-util-2 branch January 29, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants