Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions #48

Closed
VaeterchenFrost opened this issue Dec 18, 2024 · 2 comments · Fixed by #47
Closed

Update Github Actions #48

VaeterchenFrost opened this issue Dec 18, 2024 · 2 comments · Fixed by #47
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@VaeterchenFrost
Copy link
Owner

Solves issues like:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2, EndBug/add-and-commit@v4. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

@VaeterchenFrost VaeterchenFrost added the dependencies Pull requests that update a dependency file label Dec 18, 2024
@VaeterchenFrost VaeterchenFrost self-assigned this Dec 18, 2024
VaeterchenFrost added a commit that referenced this issue Dec 18, 2024
Use latest GitHub actions:
---
- https://github.com/marketplace/actions/checkout
- https://github.com/marketplace/actions/setup-python
- https://github.com/marketplace/actions/setup-graphviz
- ...

Upgrade tests to Python 3.12
No compatibility issues found.
See also https://docs.python.org/3/whatsnew/changelog.html#python-3-12-0-beta-1

Use `build` instead of `setup.py`:
https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

Update Author e-mail to `author_email: [email protected]`

Simplify the installation on Windows:
---
Install graphviz using:

`choco install graphviz --version=12.2.1`

Update `environment.yml`

Add GitHub Action PostgreSQL to **PATH**
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-environment-variable

Solves #48
@VaeterchenFrost VaeterchenFrost linked a pull request Dec 18, 2024 that will close this issue
@VaeterchenFrost
Copy link
Owner Author

VaeterchenFrost commented Dec 18, 2024

Also taking care of basic steps towards https://setuptools.pypa.io/en/latest/userguide/quickstart.html#setuppy-discouraged
https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

  • Replacing installation of setuptools with

    pip install 'build[virtualenv]'

  • Replacing old python setup.py sdist bdist_wheel with

    python -m build

@VaeterchenFrost
Copy link
Owner Author

The setup.py script is used for combining the

long_description = read_files(["README.md", "CHANGELOG.md"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant