Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Actions and Dependencies #47

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Conversation

VaeterchenFrost
Copy link
Owner

Use latest GitHub actions:

Use build instead of setup.py:
https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

Simplify the installation of Graphviz on Windows.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.32%. Comparing base (d57db2c) to head (236b4e6).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
tdvisu/visualization.py 90.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   89.01%   89.32%   +0.30%     
==========================================
  Files           8        8              
  Lines         974      974              
==========================================
+ Hits          867      870       +3     
+ Misses        107      104       -3     
Flag Coverage Δ
unittests 89.32% <95.65%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VaeterchenFrost VaeterchenFrost force-pushed the upgrade-build-steps branch 3 times, most recently from 9f514d9 to 7f80746 Compare December 17, 2024 15:20
@VaeterchenFrost VaeterchenFrost self-assigned this Dec 17, 2024
@VaeterchenFrost VaeterchenFrost added the enhancement New feature or request label Dec 17, 2024
@VaeterchenFrost VaeterchenFrost force-pushed the upgrade-build-steps branch 10 times, most recently from a3e7e77 to 1ffa54f Compare December 18, 2024 18:18
Use latest GitHub actions:
---
- https://github.com/marketplace/actions/checkout
- https://github.com/marketplace/actions/setup-python
- https://github.com/marketplace/actions/setup-graphviz
- ...

Upgrade tests to Python 3.12
No compatibility issues found.
See also https://docs.python.org/3/whatsnew/changelog.html#python-3-12-0-beta-1

Use `build` instead of `setup.py`:
https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

Update Author e-mail to `author_email: [email protected]`

Simplify the installation on Windows:
---
Install graphviz using:

`choco install graphviz --version=12.2.1`

Update `environment.yml`

Add GitHub Action PostgreSQL to **PATH**
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-environment-variable

Solves #48
This commit does:
---
Upgrade requirements

Upgrade to
- [psycopg](https://pypi.org/project/psycopg)==3.2.3
- [pytest](https://pypi.org/project/pytest)==8.3.4

Update and format `setup.py`

## Generated by graphviz version 12.2.1
Changed the output files slightly with the test settings. They look a bit cleaner, see also [CHANGELOG](https://gitlab.com/graphviz/graphviz/-/blob/main/CHANGELOG.md)

Update `expected_files\test_sat_and_join`

Update `expected_files\test_vc_multiple_and_join`

Psycopg 3
---
Specifying `psycopg[c]` for distribution: https://www.psycopg.org/psycopg3/docs/basic/install.html#local-installation
See [Installation](https://www.psycopg.org/psycopg3/docs/basic/install.html#installation) for the other options during installation.

```shell
pip install psycopg
```

without [c] or [binary] extras you will obtain a pure Python implementation. This is particularly handy to debug and hack, but it still requires the system libpq to operate (which will be imported dynamically via ctypes)..

## This commit does:
- replace the import of `psycopg2` with **psycopg**
- update "wait for good connection" replacing the  `good_db_status()` method with **pg.pq.ConnStatus.OK**
- replace `pg.extensions` module
- replace `db.get_transaction_status()` with the **db.info.status** property, changing the semantics slightly.

Graphviz-version: 12.2.1
---
See https://graphviz.org/download for details.

Build --with-gts
> https://gts.sourceforge.net/
> https://stackoverflow.com/a/42579735/12656297
Format imports and lines with https://marketplace.visualstudio.com/items?itemName=ms-python.black-formatter

Add pragmas for new lines. Expected to **decrease coverage** by a few percent because of the better looking lines ;)
Update `# Using` section.
Several updates in PR #47
@VaeterchenFrost VaeterchenFrost linked an issue Dec 18, 2024 that may be closed by this pull request
@VaeterchenFrost VaeterchenFrost changed the title Upgrade build steps Upgrade Actions and Dependencies Dec 18, 2024
Copy link
Owner Author

@VaeterchenFrost VaeterchenFrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge.

Update version and CHANGELOG for minor release.
@VaeterchenFrost VaeterchenFrost merged commit d06ca9a into master Dec 19, 2024
7 checks passed
@VaeterchenFrost VaeterchenFrost deleted the upgrade-build-steps branch December 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Github Actions
1 participant