Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests #7

Open
VaeterchenFrost opened this issue Jun 1, 2020 · 3 comments
Open

Add more tests #7

VaeterchenFrost opened this issue Jun 1, 2020 · 3 comments
Labels
good first issue Good for newcomers
Milestone
Version 1.2

Comments

@VaeterchenFrost
Copy link
Owner

VaeterchenFrost commented Jun 1, 2020 •
edited
Loading

Can regression-test more intermed steps.

Use functionality in folder \test

See https://changhsinlee.com/pytest-mock/ for mocking in pytest (testing database e.g.)
@VaeterchenFrost
Copy link
Owner Author

VaeterchenFrost commented Jun 1, 2020 •
edited
Loading

version.py:

  • version (regex)
  • date (y-m-d)

@VaeterchenFrost VaeterchenFrost added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Jun 1, 2020
@VaeterchenFrost VaeterchenFrost added this to the First Release milestone Jun 1, 2020
@VaeterchenFrost VaeterchenFrost added the good first issue Good for newcomers label Jun 1, 2020
VaeterchenFrost added a commit that referenced this issue Jun 1, 2020
@VaeterchenFrost
Create test_version.py
297f32b 
#7 Added Test for valid __date__ and __version__
VaeterchenFrost added a commit that referenced this issue Jun 3, 2020
@VaeterchenFrost
test every branch
b5df5ab 
#7
@VaeterchenFrost
Copy link
Owner Author

#15

VaeterchenFrost added a commit that referenced this issue Jun 4, 2020
@VaeterchenFrost
Parametrize TestGenArg
bc144bc 
Now everything in test_gen_arg.
#7
VaeterchenFrost added a commit that referenced this issue Jun 4, 2020
@VaeterchenFrost
Updated TestAppendSvg, now function
5087208 
Now test_append_svg parametrized.
Much more tightly arranged.
#13 #7
VaeterchenFrost added a commit that referenced this issue Jun 4, 2020
@VaeterchenFrost
Added test results
0454ff2 
Manually reviewed the results and found no errors.
Could need some rounding, will add rounding next.
#13 #7
VaeterchenFrost added a commit that referenced this issue Jun 4, 2020
@VaeterchenFrost
Added test_append_svg_pinned
5183db9 
#7 Pinned and padded results
VaeterchenFrost added a commit that referenced this issue Jun 6, 2020
@VaeterchenFrost
Add utilities.py
5f0c5ba 
Factor out common  helper methods.
Makes files easier to read, imports easier.
#7
VaeterchenFrost added a commit that referenced this issue Jun 6, 2020
@VaeterchenFrost
Configure logging (#20)
66d18d1 
#19

* Update construct_dpdb_visu.py

Added main()
Moved import argparse to toplevel
in construct rename generalGraph to general_gr

* Update logging

* Update main docstring

+ Renamed ARGS to _args
+ argparse on toplevel import
+ sorted imports

* Update visualization.py

* Create logging.yml

* Remove logging.basicConfig

* Explicit logger names

Same as in logging.yml #19

* Update logging.yml

Update formatter

* Add utilities.py

Factor out common  helper methods.
Makes files easier to read, imports easier.
#7

* Move static methods to utilities

The static methods were generic enough to be a utility.
Other than that it helps to keep visualization.py more slim to just import these methods.
Some Format.

* Update read_cfg with read_yml_or_cfg

#19

Using utility method to read different cfg formats.

* Update test_bag_creation.py

Use utility

* Update logging Setup

Setup with utilities DefaultLoggingCfg

* Factored logging config dpdb into utilities

#19

* Some type refactoring

using int/float correctly

* Favtored logging out in visualization.py

Other main application that needs logging config.
#19

* loglevel default to None

loglevel=None means take what the config says.
The commandline parameter takes precedence over config.
If not None: update 'root' logger and it's handlers to that level. #19 #20

* Added logging.ini for comparison

Much more verbose, handlers+qualname needed most likely.
Updated logging.yml with WARNING default and all loggers use the root handler https://docs.python.org/3/howto/logging.html#logging-flow
#19

* Comments, Changelog

Comment basicConfig (provide information until logging is set up).

* Update svgjoin.py

Fixed wrong conversion to int.
Added better typing for f_transform
VaeterchenFrost added a commit that referenced this issue Jun 6, 2020
@VaeterchenFrost
Update test_utilities.py
51b1768 
Test
- flatten
- convert_to_adj
- add_edge_to
#7
VaeterchenFrost referenced this issue Jun 25, 2020
@VaeterchenFrost
Create test_dijkstra.py
6fd0e96 
testing dijkstra.py
VaeterchenFrost added a commit that referenced this issue Jun 26, 2020
@VaeterchenFrost
Create test_reader.py
d3eefd5 
#7
VaeterchenFrost added a commit that referenced this issue Jul 11, 2020
@VaeterchenFrost
Writing a integration test for multiple graphs
aa31901 
#9
#7
VaeterchenFrost added a commit that referenced this issue Jul 11, 2020
@VaeterchenFrost
Create test_construct_dpdb.py
b81ba9b 
#7
VaeterchenFrost added a commit that referenced this issue Jul 11, 2020
@VaeterchenFrost
Tests for reading db config and defaults
ea7e985 
Added
test_db_config
test_db2_config
test_db_passwd_config
#7
@VaeterchenFrost VaeterchenFrost mentioned this issue Jul 13, 2020
Merged
VaeterchenFrost added a commit that referenced this issue Jul 15, 2020
@VaeterchenFrost
Add tests specifically for read config
df31d8d 
testing edge cases
#7
@VaeterchenFrost VaeterchenFrost mentioned this issue Jul 16, 2020
Merged
@VaeterchenFrost
Copy link
Owner Author

How to test if __name__ == ‘__main__’
https://medium.com/opsops/how-to-test-if-name-main-1928367290cb

https://gist.github.com/amarao/5d0d4346f9ce6183d05bdae197ba1fc4

VaeterchenFrost added a commit that referenced this issue Jul 16, 2020
@VaeterchenFrost
Refactor and test init()
29d0032 
Using sys.exit as insurance that test call is executed correclty. #7

Needs import sys in module
VaeterchenFrost added a commit that referenced this issue Jul 16, 2020
@VaeterchenFrost
Refactor entrypoints (#28)
1ce18ee 
* Create utilities.get_parser

Factor out common logic into utilities.
Removes some dependencies and code duplications.

* Use parser in main()

See answer https://stackoverflow.com/questions/37697502/python-unittest-for-argparse
for reference.
Also updated docstrings

* Make testable as init

* Refactor and test init()

Using sys.exit as insurance that test call is executed correclty. #7

Needs import sys in module

* Refactored calls in tests to main

Now even simpler tests! No argparse.

* format
@VaeterchenFrost VaeterchenFrost removed documentation Improvements or additions to documentation help wanted Extra attention is needed labels Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Version 1.2
Development

No branches or pull requests
1 participant
@VaeterchenFrost