Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pragma: no cover in construct_dpdb #27

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Add pragma: no cover in construct_dpdb #27

merged 3 commits into from
Jul 16, 2020

Conversation

VaeterchenFrost
Copy link
Owner

See https://coverage.readthedocs.io/en/coverage-5.0.3/excluding.html

Improves work on #7 by specifying places that are "okay" not to test,
like db calls and code that should not be run by the user.

@VaeterchenFrost VaeterchenFrost self-assigned this Jul 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #27 into master will increase coverage by 3.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   82.08%   85.78%   +3.70%     
==========================================
  Files           9        9              
  Lines        1038      978      -60     
==========================================
- Hits          852      839      -13     
+ Misses        186      139      -47     
Flag Coverage Δ
#unittests 85.78% <ø> (+3.70%) ⬆️
Impacted Files Coverage Δ
tdvisu/construct_dpdb_visu.py 76.19% <ø> (+10.29%) ⬆️
tdvisu/dijkstra.py 94.64% <ø> (+4.64%) ⬆️
tdvisu/svgjoin.py 91.96% <ø> (+1.52%) ⬆️
tdvisu/utilities.py 84.88% <ø> (ø)
tdvisu/visualization_data.py 100.00% <ø> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a461e7...483184e. Read the comment docs.

Added ` # pragma: no cover` to __main__
that is only a example by its own and should not be run by user code.
Only construct_dpdb_visu and visualization have mains that are run by users.
@VaeterchenFrost
Copy link
Owner Author

How to test if __name__ == ‘__main__’
https://medium.com/opsops/how-to-test-if-name-main-1928367290cb

missed cases where only one direction is cropped.
added and removed spaces where needed
@VaeterchenFrost VaeterchenFrost merged commit 51dd14a into master Jul 16, 2020
@VaeterchenFrost VaeterchenFrost deleted the add-nocov branch July 16, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants