Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Footer #10

Merged
merged 4 commits into from
May 28, 2024
Merged

Added Footer #10

merged 4 commits into from
May 28, 2024

Conversation

Hemashree21
Copy link
Contributor

Resolved issue #6

image

I have added the footer and also made it responsive, if in the future you want to add some more social handles, you can add it next to that. Also, the links in the footer are not routed.

@VaibhavArora314 please check and let me know if any changes are required.

Signed-off-by: Hemashree M S <[email protected]>
Copy link

vercel bot commented May 28, 2024

@Hemashree21 is attempting to deploy a commit to the vaibhav's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 3:09pm

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add package.json and .gitignore in the root of the repo? also, there is no need to use mui icons just for one GitHub icon. you can use an SVG or an icon for it, so remove all the unnecessary packages installed.

Signed-off-by: Hemashree M S <[email protected]>
@Hemashree21
Copy link
Contributor Author

@VaibhavArora314 I have made the changes and I have deleted the mui package

@VaibhavArora314
Copy link
Owner

@Hemashree21 Remove package.json files and node_modules from the root directory. also uninstall @emotion/styled from the frontend, since we are not using this.

@Hemashree21
Copy link
Contributor Author

@VaibhavArora314 I have removed them

@VaibhavArora314
Copy link
Owner

VaibhavArora314 commented May 28, 2024

@Hemashree21 you have only removed node_modules, also remove package.json and package-lock.json from the root directory.
Screenshot 2024-05-28 203338

Also, uninstall "@emotion/styled" from the frontend since it is not used.
image

Signed-off-by: Hemashree M S <[email protected]>
@Hemashree21
Copy link
Contributor Author

@VaibhavArora314 I have removed everything now sir

@VaibhavArora314 VaibhavArora314 merged commit 01c6e7e into VaibhavArora314:main May 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants