-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Footer #10
Added Footer #10
Conversation
Signed-off-by: Hemashree M S <[email protected]>
@Hemashree21 is attempting to deploy a commit to the vaibhav's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add package.json and .gitignore in the root of the repo? also, there is no need to use mui icons just for one GitHub icon. you can use an SVG or an icon for it, so remove all the unnecessary packages installed.
Signed-off-by: Hemashree M S <[email protected]>
@VaibhavArora314 I have made the changes and I have deleted the mui package |
@Hemashree21 Remove package.json files and node_modules from the root directory. also uninstall @emotion/styled from the frontend, since we are not using this. |
Signed-off-by: Hemashree M S <[email protected]>
@VaibhavArora314 I have removed them |
@Hemashree21 you have only removed node_modules, also remove package.json and package-lock.json from the root directory. Also, uninstall "@emotion/styled" from the frontend since it is not used. |
Signed-off-by: Hemashree M S <[email protected]>
@VaibhavArora314 I have removed everything now sir |
Resolved issue #6
I have added the footer and also made it responsive, if in the future you want to add some more social handles, you can add it next to that. Also, the links in the footer are not routed.
@VaibhavArora314 please check and let me know if any changes are required.