Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll to top is added #104

Closed
wants to merge 5 commits into from
Closed

scroll to top is added #104

wants to merge 5 commits into from

Conversation

manikumarreddyu
Copy link
Contributor

new feature

Pull Request

Title

added scroll to top button

Description

created two file in components folder
1.scrolltotop.tsx
2.scrolltotop.css

I have tested the changes locally

Screenshots (if applicable)

image

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 3:54pm

Copy link

github-actions bot commented Jun 3, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, just one thing. don't use plain CSS because the project is using tailwind CSS and it is a good practice to maintain consistency throughout the project.

@manikumarreddyu
Copy link
Contributor Author

ok ..i will change it to tailwind css..np

scroll to top updated with tailwind css
@manikumarreddyu
Copy link
Contributor Author

completed
fixed #95

@VaibhavArora314
Copy link
Owner

resolve merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants