Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added light/dark mode #268

Merged
merged 10 commits into from
Jun 21, 2024
Merged

Conversation

manikumarreddyu
Copy link
Contributor

@manikumarreddyu manikumarreddyu commented Jun 20, 2024

Pull Request

Title

Added light/dark mode

Description

Added light/dark mode

Related Issues

fixes : #115

Changes Made

many changes

Checklist

  • I have tested the changes locally
  • Documentation has been updated (if necessary)
  • Changes are backward-compatible

Screenshots (if applicable)

can see in preview

Additional Notes

nothing

Footer

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 7:09am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. NewPost Page
    image
  2. Filter button and search input color
    image
  3. Provide only 1 button for theme, remove button for theme for code window
    image
  4. Loader coming in dark mode even when light mode selected
    image

@VaibhavArora314
Copy link
Owner

I suggest that you break the pr into smaller prs, since there will be various conflicts and it will be easier for you to resolve and easier for me to review

@manikumarreddyu
Copy link
Contributor Author

I suggest that you break the pr into smaller prs, since there will be various conflicts and it will be easier for you to resolve and easier for me to review

okay @VaibhavArora314

@manikumarreddyu
Copy link
Contributor Author

manikumarreddyu commented Jun 20, 2024

upto now

faq.tsx
features.tsx
navbar.tsx
postcard.tsx
showcase.tsx
about.tsx
comment,tsx
contactus.tsx
editpost.tsx
favourites.tsx
home.tsx
homepage.tsx
homepageposts.tsx
leaderboard.tsx
policy.tsx
posts.tsx
profile.tsx
showprofile.tsx
sigin.tsx
signup.tsx

are completed

Dont merge any other PR before this

Give me time upto TODAY AFTERNOON , I WILL COMPLETE MY JOB

DATE : 21/06/2024 ..UPTO 1 PM ..

WE WILL COMPLETE ALL ISSUES REGARDING THESE ...PLEASE CONSIDER MY REQUEST

@manikumarreddyu
Copy link
Contributor Author

PLEASE MERGE UPTO THIS ..Everything is completed.

IF there is any suggestions for that we create it under new issue...otherwise all the hard work will go off...we will stuck in a loop

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is looking good. there are minor bugs that can be solved in separate issues.

@VaibhavArora314 VaibhavArora314 merged commit c1f3bf6 into VaibhavArora314:main Jun 21, 2024
3 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ligh/Dark Mode
2 participants