Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added route name on every tab successfully Issue 321 #324

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jun 26, 2024

Pull Request Resolves [#321 ]

Title: Added route name on every tab successfully.

Description

  1. I put the tab name on every possible places with the help of document.title feature.
  2. With this user can see the tabs information easily and navigate seamlessly across the platform.
  3. Used emoji's and fun text to make it interactive and user friendly.

Related Issues

Fixes #321

Changes Made

New features: Added route name on every tab.

Screenshots

  1. Home Page

image

  1. Posts Page

image

  1. Leaderboard

image

and similarly for the rest of them.

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 8:29am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve merge conflicts. also, did you push changes of the categories pull request?

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 28, 2024

resolve merge conflicts. also, did you push changes of the categories pull request?

@VaibhavArora314 I keep on forgotting about it, sorry my bad i merge category also 😢

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 28, 2024

Hey @VaibhavArora314 can you tell me how should i work on that admin like i should create all the api in the backend only and for frontend i have to put all in admin folder is that right ?

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 28, 2024

@VaibhavArora314 Done 👍

@VaibhavArora314
Copy link
Owner

Hey @VaibhavArora314 can you tell me how should i work on that admin like i should create all the api in the backend only and for frontend i have to put all in admin folder is that right ?

you should create a separate route for them like /api/admin/v1/ for admin routes

@VaibhavArora314 VaibhavArora314 merged commit c2f0edb into VaibhavArora314:main Jun 28, 2024
3 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jun 28, 2024

Hey @VaibhavArora314 can you tell me how should i work on that admin like i should create all the api in the backend only and for frontend i have to put all in admin folder is that right ?

you should create a separate route for them like /api/admin/v1/ for admin routes

I got that but I will create all API in backend folder only na and for frontend in admin folder ?

@VaibhavArora314
Copy link
Owner

Hey @VaibhavArora314 can you tell me how should i work on that admin like i should create all the api in the backend only and for frontend i have to put all in admin folder is that right ?

you should create a separate route for them like /api/admin/v1/ for admin routes

I got that but I will create all API in backend folder only na and for frontend in admin folder ?

yes backend will remain in the same folder, only the frontend for admin will be in separate folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding name on every tab while navigating through pages
3 participants