-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added route name on every tab successfully Issue 321 #324
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve merge conflicts. also, did you push changes of the categories pull request?
@VaibhavArora314 I keep on forgotting about it, sorry my bad i merge category also 😢 |
Hey @VaibhavArora314 can you tell me how should i work on that admin like i should create all the api in the backend only and for frontend i have to put all in admin folder is that right ? |
@VaibhavArora314 Done 👍 |
you should create a separate route for them like /api/admin/v1/ for admin routes |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
I got that but I will create all API in backend folder only na and for frontend in admin folder ? |
yes backend will remain in the same folder, only the frontend for admin will be in separate folder |
Pull Request Resolves [#321 ]
Title: Added route name on every tab successfully.
Description
Related Issues
Fixes #321
Changes Made
New features: Added route name on every tab.
Screenshots
and similarly for the rest of them.
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.