Feat/editable profile #376

anwesha2002 · 2024-07-05T20:58:28Z

Pull Request

Title

Feature update : Editable profile #127

Description

this PR adds the feature of the editable profile. User can edit their profile in profile section

Related Issues

Fixes #127

Changes Made

An edit form added for user profile update.
profile_update route and controller is added in the backend
All the necessary changes made in the frontend and the backend for this feature
Zod verification is also taken care of

Checklist

[x ] I have tested the changes locally
[x ] Documentation has been updated (if necessary)
[x ] Changes are backward-compatible

Screenshots (if applicable)

Recording.2024-07-06.022704.mp4

Additional Notes

HMU if any changes needed

Footer

… feat/editable_profile

vercel · 2024-07-05T20:58:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
style-share	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2024 3:01pm

github-actions · 2024-07-05T20:58:39Z

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

VaibhavArora314

resolve these errors

VaibhavArora314

looks good to me, some things to change:

don't use contains in updating as it is affecting all users
check if email already in use by other user
if user changes email, mark user verified status to false

anwesha2002 · 2024-07-06T07:20:19Z

@VaibhavArora314 I think there is no function named 'updateFirst'. in order to do so first will have to do findFirst and then 'update' that record. otherwise if i use updateMany, all the data contains that userID will be updated means in follow list, or in post or where ever it is in use.
so should I change it??

VaibhavArora314 · 2024-07-06T07:28:18Z

don't use contains while updating since that is affecting multiple users. you can use updateMany but don't use contains for id in where

anwesha2002 · 2024-07-06T08:22:45Z

don't use contains while updating since that is affecting multiple users. you can use updateMany but don't use contains for id in where

okay

akbatra567 · 2024-07-06T19:09:07Z

frontend/src/components/profileForm.tsx

+            toast.success(response.data.message)
+            dismiss()
+        }catch (e){
+            const axiosError = e as AxiosError<{


Avoid as whenever possible as it does a force conversion to the specified type.

Potential solution is:

Suggested change

const axiosError = e as AxiosError<{

const axiosError: AxiosError<{ error: { message: string; }}> = e;

You would need to test if it directly works also if you fell the error is commonly used, you can create a type and pass directly.

For instance:

type ErrorType = { error: { message: string; }}; const axiosError: AxiosError<ErrorType> = e;

akbatra567 · 2024-07-06T19:13:28Z

frontend/src/components/profileForm.tsx

+
+            setError((e) => {
+                if (axiosError?.response?.data?.error)
+                    return axiosError?.response?.data?.error as typeof e;


See here also if you can avoid type convertion using as keyword. If it doesn't work you can avoid. Do try and let me know.

… feat/editable_profile # Conflicts: # backend/src/routes/user/route.ts # frontend/src/App.tsx

VaibhavArora314

looking good but after the user updates his details, the updated details should be shown on the profile as currently, it is showing old details and user has to reload to see updated details

… feat/editable_profile

anwesha2002 · 2024-07-11T15:01:31Z

looking good but after the user updates his details, the updated details should be shown on the profile as currently, it is showing old details and user has to reload to see updated details

is it okay now??

github-actions · 2024-07-12T16:15:16Z

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

anwesha added 3 commits July 6, 2024 01:41

feat:editable_profile_feature_added

4f01c13

Merge branch 'main' of https://github.com/anwesha2002/StyleShare into…

e52081c

… feat/editable_profile

refac:error_message

74e056f

vercel bot had a problem deploying to Preview July 5, 2024 20:58 Failure

refac:deployment_error_fixed

39d9fe6

VaibhavArora314 requested changes Jul 6, 2024

View reviewed changes

VaibhavArora314 requested review from akbatra567 and Ultimateutkarsh11 July 6, 2024 07:00

vercel bot deployed to Preview July 6, 2024 07:02 View deployment

anwesha2002 requested a review from VaibhavArora314 July 6, 2024 07:02

VaibhavArora314 requested changes Jul 6, 2024

View reviewed changes

akbatra567 reviewed Jul 6, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

anwesha added 3 commits July 11, 2024 15:45

refac:Same_email_check__type_conversion_changed

6e2256a

Merge branch 'main' of https://github.com/anwesha2002/StyleShare into…

120268a

… feat/editable_profile # Conflicts: # backend/src/routes/user/route.ts # frontend/src/App.tsx

refac:verified_false_on_email_change

3d33bcd

vercel bot deployed to Preview July 11, 2024 10:38 View deployment

anwesha2002 requested review from VaibhavArora314, Ultimateutkarsh11 and akbatra567 July 11, 2024 10:38

refac:some_deployment_changes

5954421

vercel bot deployed to Preview July 11, 2024 10:41 View deployment

VaibhavArora314 requested changes Jul 11, 2024

View reviewed changes

refac:page_reload_after_update_details

ae814d8

Merge branch 'main' of https://github.com/anwesha2002/StyleShare into…

65361a6

… feat/editable_profile

anwesha2002 requested a review from VaibhavArora314 July 11, 2024 15:01

vercel bot deployed to Preview July 11, 2024 15:01 View deployment

VaibhavArora314 approved these changes Jul 11, 2024

View reviewed changes

Ultimateutkarsh11 approved these changes Jul 12, 2024

View reviewed changes

akbatra567 approved these changes Jul 12, 2024

View reviewed changes

akbatra567 merged commit ff8b982 into VaibhavArora314:main Jul 12, 2024
3 checks passed

Ultimateutkarsh11 assigned anwesha2002 Jul 12, 2024

Ultimateutkarsh11 added gssoc GSSOC level2 enhancement New feature or request labels Jul 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/editable profile #376

Feat/editable profile #376

anwesha2002 commented Jul 5, 2024

vercel bot commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024

VaibhavArora314 left a comment

VaibhavArora314 left a comment •

edited

Loading

anwesha2002 commented Jul 6, 2024

VaibhavArora314 commented Jul 6, 2024 •

edited

Loading

anwesha2002 commented Jul 6, 2024

akbatra567 Jul 6, 2024

akbatra567 Jul 6, 2024

This comment was marked as resolved.

VaibhavArora314 left a comment •

edited

Loading

anwesha2002 commented Jul 11, 2024

github-actions bot commented Jul 12, 2024

	const axiosError = e as AxiosError<{
	const axiosError: AxiosError<{ error: { message: string; }}> = e;

Feat/editable profile #376

Feat/editable profile #376

Conversation

anwesha2002 commented Jul 5, 2024

Pull Request

Title

Description

Related Issues

Changes Made

Checklist

Screenshots (if applicable)

Additional Notes

vercel bot commented Jul 5, 2024 • edited Loading

github-actions bot commented Jul 5, 2024

VaibhavArora314 left a comment

Choose a reason for hiding this comment

VaibhavArora314 left a comment • edited Loading

Choose a reason for hiding this comment

anwesha2002 commented Jul 6, 2024

VaibhavArora314 commented Jul 6, 2024 • edited Loading

anwesha2002 commented Jul 6, 2024

akbatra567 Jul 6, 2024

Choose a reason for hiding this comment

akbatra567 Jul 6, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

VaibhavArora314 left a comment • edited Loading

Choose a reason for hiding this comment

anwesha2002 commented Jul 11, 2024

github-actions bot commented Jul 12, 2024

vercel bot commented Jul 5, 2024 •

edited

Loading

VaibhavArora314 left a comment •

edited

Loading

VaibhavArora314 commented Jul 6, 2024 •

edited

Loading

VaibhavArora314 left a comment •

edited

Loading