-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Fetched Trending and New Posts in admin dashboard successfully Issue 366 #385
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@VaibhavArora314 @Ultimateutkarsh11 @akbatra567 please review this 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not provide fields such as email on the posts endpoint since email has to be hidden, rather you can create a separate endpoint for admin/post to get posts with email and other extra details.
@VaibhavArora314 Done the changes as requested level 3 because of api and frontend 😄 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change route names to /admin/posts/all and /admin/posts/trending
@VaibhavArora314 Changed the routes as per request 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeetDOD kindly resolve the merge conflicts
Done please add level 3 label because of api + frontend 😄 |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
@Ultimateutkarsh11 can i work on issue #389 now because the block feature is done ? |
Yes, go ahead. |
Pull Request Resolves [#366 ]
Title: Fetched Trending and New Posts in admin dashboard successfully.
Description
Related Issues
Fixes #366
Changes Made
New features: Fetched Trending and New Posts in admin dashboard.
Screenshots
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.