Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fetched Trending and New Posts in admin dashboard successfully Issue 366 #385

Merged
merged 8 commits into from
Jul 8, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Jul 6, 2024

Pull Request Resolves [#366 ]

Title: Fetched Trending and New Posts in admin dashboard successfully.

Description

  1. I am fetching the posts of total 6 in both the table, fetching from posts with pagination and the trending posts.
  2. Created interface for post and user.

Related Issues

Fixes #366

Changes Made

New features: Fetched Trending and New Posts in admin dashboard.

Screenshots

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Jul 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 9:12am

Copy link

github-actions bot commented Jul 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 7, 2024

@VaibhavArora314 @Ultimateutkarsh11 @akbatra567 please review this 😄

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not provide fields such as email on the posts endpoint since email has to be hidden, rather you can create a separate endpoint for admin/post to get posts with email and other extra details.

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 7, 2024

@VaibhavArora314 Done the changes as requested level 3 because of api and frontend 😄 !

admin/src/components/NewPosts.tsx Outdated Show resolved Hide resolved
admin/src/components/TrendingPosts.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change route names to /admin/posts/all and /admin/posts/trending

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 8, 2024

change route names to /admin/posts/all and /admin/posts/trending

@VaibhavArora314 Changed the routes as per request 👍

Copy link
Collaborator

@Ultimateutkarsh11 Ultimateutkarsh11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeetDOD kindly resolve the merge conflicts

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 8, 2024

@MeetDOD kindly resolve the merge conflicts

Done please add level 3 label because of api + frontend 😄

@Ultimateutkarsh11 Ultimateutkarsh11 merged commit 565cd6e into VaibhavArora314:main Jul 8, 2024
3 checks passed
Copy link

github-actions bot commented Jul 8, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@MeetDOD
Copy link
Contributor Author

MeetDOD commented Jul 8, 2024

@Ultimateutkarsh11 can i work on issue #389 now because the block feature is done ?

@Ultimateutkarsh11
Copy link
Collaborator

@Ultimateutkarsh11 can i work on issue #389 now because the block feature is done ?

Yes, go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GSSOC level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Fetching Trending and New Posts in admin dashboard
4 participants