Feat: Created manage user by admin block/unblock users based on their activity successfully Issue 338 #388
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
@VaibhavArora314 @Ultimateutkarsh11 @akbatra567 review this PR ASAP because I want to add this issue also #389 |
| username: string; | ||
| email: string; | ||
| verified: boolean; | ||
| blocked: boolean; |
There was a problem hiding this comment.
change the attribute name according to naming convention.
Refer these links:
There was a problem hiding this comment.
We aren't using any naming convention in this project so, this isn't any issue from the beginning!
There was a problem hiding this comment.
Naming convention comes from language irrespective of project.
Refer this for Typescript:
https://gist.github.com/anichitiandreea/e1d466022d772ea22db56399a7af576b#naming-booleans
There was a problem hiding this comment.
Hey @akbatra567, these variable names are coming from Prisma schema and to edit these, there will be a lot of changes in whole applications since these names are used in various places. I think that we can raise a separate issue for changing this throughout since this will be out of the scope of this pull request.
There was a problem hiding this comment.
Sure then, if you feel that way. Approving this then.
It's 1am, @MeetDOD you need to be mindful of the time and not tag everyone on any random hour. Open Source is a community level initiatives. Don't force others to work on any random hour if you're working late. Everyone has their own personal and professional working hours. |
If you are busy then ignore the dm, i am not forcing you to work or see the pr specifically you can also reply on morning also. |
@VaibhavArora314 I created the interface in this pr https://github.com/MeetDOD/StyleShare/blob/issue-366/admin/src/types.ts |
|
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
|
@VaibhavArora314 @Ultimateutkarsh11 add level 3 please 🙏 |
|
@Ultimateutkarsh11 Thank you for the guidence ! |
Pull Request Resolves [#338]
Title: Created manage user by admin block/unblock users based on their activity successfully.
Description
Related Issues
Fixes #338
Changes Made
New features: Created manage user by admin block/unblock users based on their activity.
Screenshots
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.