Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated login and signup #407

Merged
merged 11 commits into from
Jul 16, 2024
Merged

updated login and signup #407

merged 11 commits into from
Jul 16, 2024

Conversation

Sailesh3000
Copy link
Contributor

@Sailesh3000 Sailesh3000 commented Jul 10, 2024

Pull Request

Title

Updated login and signup form for this issue #395

Checklist

  • [X ] I have tested the changes locally

Screenshots (if applicable)

image

Please assign this PR gssoc and level label thank you.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 3:49am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Sailesh3000
Copy link
Contributor Author

Why my deployment is failing can you please check it.

@VaibhavArora314
Copy link
Owner

image
@Sailesh3000 resolve error

Copy link
Collaborator

@Ultimateutkarsh11 Ultimateutkarsh11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sailesh3000 also resolve the merge conflicts

@Sailesh3000
Copy link
Contributor Author

I think its ok now please assign gssoc label and level label

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes

  1. In current website signup page:
    image
    After your changes:
    image
    Make it look like before because it is not looking good
  2. The page route should also update when the user changes signin and signup page
  3. Is it possible to improve the styling of this bar as it is not looking very good
    image

@Sailesh3000
Copy link
Contributor Author

image
image
Now i think its good page route is also changing

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  1. In dark mode, the option other than selected is too light
  2. also if I am on the signin page, and I press the signup button of this bar the route is not updated even though signup page is shown

@Sailesh3000
Copy link
Contributor Author

Sorry I did not notice that. I think its ok now.

@Sailesh3000
Copy link
Contributor Author

I think it's ok now Please still you need any changes please inform.

@VaibhavArora314
Copy link
Owner

resolve merge conflicts rest is good

@Sailesh3000
Copy link
Contributor Author

yeah done with that

@akbatra567 akbatra567 merged commit ca33d47 into VaibhavArora314:main Jul 16, 2024
2 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants