Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue 404 #419

Conversation

Saksham2k3s
Copy link
Contributor

Pull Request

Title

Redirect to User Profile on Click of Profile Tab in Leaderboard

Description

This pull request adds functionality to redirect users to their profile page when they click on the profile tab in the leaderboard.

Related Issues

Fixes #404

Changes Made

  • Added a Link component around the profile image in the leaderboard.
  • Updated the path to include the user's ID for profile redirection.

Checklist

  • I have tested the changes locally
  • Documentation has been updated (if necessary)
  • Changes are backward-compatible

Screenshots (if applicable)

Additional Notes

Footer

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 5:10pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@@ -52,7 +52,9 @@ const LeaderBoard = () => {
</td>
<td className="px-2 py-4 sm:px-6">
<div className="flex flex-col items-center">
<img className="h-8 w-8 rounded-full" src={`https://ui-avatars.com/api/?name=${user?.username}&background=0ea5e9&color=fff&rounded=true&bold=true`} alt="profile-pic" />
<Link to={`/app/profile/${user.userId}`}>
<img className="h-8 w-8 rounded-full" src={`https://ui-avatars.com/api/?name=${user?.username}&background=0ea5e9&color=fff&rounded=true&bold=true`} alt="profile-pic" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of making the image clickable, how about we make the whole row clickable ?
As we are redirecting to the user profile only.

cc: @VaibhavArora314

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of making the image clickable, how about we make the whole row clickable ? As we are redirecting to the user profile only.

cc: @VaibhavArora314

good suggestion, @Saksham2k3s please make these changes instead

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't delete package-lock.json, just undo the changes done to it

Copy link
Collaborator

@Ultimateutkarsh11 Ultimateutkarsh11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saksham2k3s kindly resolve the merge conflicts, arising due to the changes made in package-lock.json

@VaibhavArora314
Copy link
Owner

@Saksham2k3s any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Redirect to User Profile on Click of Profile Tab in Leaderboard
4 participants