-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Github link in Contributor #430
Added Github link in Contributor #430
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@VaibhavArora314 @Ultimateutkarsh11 @akbatra567 Please check it and merge ! Thank You ! |
frontend/src/pages/Contributors.tsx
Outdated
<p className="text-gray-700 dark:text-gray-400 flex items-center"> | ||
<a | ||
href={contributor.html_url} | ||
className="flex items-center" | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
> | ||
<FaGithub className="mr-1" /> GitHub Profile | ||
</a> | ||
</p> | ||
</div> | ||
))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of moving the link to the github profile from the contributors image.
Make the whole card clickable so it's easier to redirect to user profile.
@akbatra567 Changes Done ! Thank You ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have made the whole card clickable now, we can remove the Github profile line
@VaibhavArora314 Done 👍🏻 |
@Ultimateutkarsh11 Kindly Check it and merge ! Thank You ! |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
Pull Request
Title
Contibutor github profile link is on image so user can't understand that make github link seperate.
Description
Add one p tag in that add link and remove link from image.
Related Issues
Fixes #418
Changes Made
Add one p tag in that add link and remove link from image.
Checklist
Screenshots (if applicable)