-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added preloader. #436
Added preloader. #436
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@@ -3,10 +3,13 @@ import ReactDOM from 'react-dom/client' | |||
import App from './App.tsx' | |||
import { RecoilRoot } from "recoil"; | |||
import './index.css' | |||
// import PreLoader from './components/Loader/Loader'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code
// import axios from "axios"; | ||
// axios.defaults.baseURL = "http://localhost:3001/"; | ||
|
||
function App() { | ||
const { theme, toggleTheme } = useTheme(); | ||
const { loading, isBlocked } = userBlock(5); | ||
const [Preloading,setLoading]= useState(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const [Preloading,setLoading]= useState(true); | |
const [preLoading,setPreLoading]= useState(true); |
Variable is not in react naming convention
Similar to https://react.dev/reference/react/useState#setstate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, just have one suggestion: instead of alternating between white and black colors in the preloader we can first show white then show black bg, and stop there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As animation have also been added to the incoming text so that would not look good ,i tried it out. It just looks like a glitch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then we can go ahead with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do the changes stated above rest is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove bun.lockb file and do above stated changes
@happyrao78 any updates? |
#412 Solved.