Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Us Page updated #448

Closed

Conversation

r7projects-shayan
Copy link
Contributor

Pull Request

Title

Updated the About Us page

Description

Updated the About Us page and made it fully responsive for all devices and dimensions
Added Interactive and sleek animations
Fixed the spacings

Related Issues

Fixes #346

Changes Made

New Features and bug fixes

Checklist

  • I have tested the changes locally
  • Documentation has been updated (if necessary)
  • Changes are backward-compatible

Screenshots (if applicable)

Video Demo

possssssssssssssssssssst.mp4

These are the screenshots

Screenshot 2024-07-14 202625
Screenshot 2024-07-14 202632
Screenshot 2024-07-14 202644
Screenshot 2024-07-14 202648
Screenshot 2024-07-14 202703
Screenshot 2024-07-14 202710
Screenshot 2024-07-14 202716
Screenshot 2024-07-14 202744
Screenshot 2024-07-14 202749
Screenshot 2024-07-14 202755
Screenshot 2024-07-14 202800
Screenshot 2024-07-14 202804

Additional Notes

Footer

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 6:11am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@r7projects-shayan
Copy link
Contributor Author

just give me some time I need to see the deployment error by deploying it on my personal vercel

@r7projects-shayan
Copy link
Contributor Author

r7projects-shayan commented Jul 15, 2024

@VaibhavArora314 Yes done now updated successfully

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, just have one suggestion that is whole website is using tailwind throughout and I don't think we should have another library for styling even though it is built top on tailwind.

@VaibhavArora314
Copy link
Owner

Also the how it works options should always be selected, we are not allowing users to select them rather we are showing what we offer and how website works

@r7projects-shayan
Copy link
Contributor Author

@VaibhavArora314 Alright I'll remove the checkbox interactivity and remove the external styling library

@r7projects-shayan
Copy link
Contributor Author

@VaibhavArora314 implemented the changes successfully

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, I have one question I wanted to ask what is lottieabout.json for?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@r7projects-shayan
Copy link
Contributor Author

@VaibhavArora314 the lottie.json is for the animation in the about us page in place of the image

@akbatra567
Copy link
Collaborator

@r7projects-shayan, resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Proper UI and Interactivity for the entire About Us Page
4 participants