-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About Us Page updated #448
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
just give me some time I need to see the deployment error by deploying it on my personal vercel |
@VaibhavArora314 Yes done now updated successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, just have one suggestion that is whole website is using tailwind throughout and I don't think we should have another library for styling even though it is built top on tailwind.
Also the how it works options should always be selected, we are not allowing users to select them rather we are showing what we offer and how website works |
@VaibhavArora314 Alright I'll remove the checkbox interactivity and remove the external styling library |
@VaibhavArora314 implemented the changes successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, I have one question I wanted to ask what is lottieabout.json for?
frontend/src/styles/about.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@VaibhavArora314 the lottie.json is for the animation in the about us page in place of the image |
@r7projects-shayan, resolve conflicts. |
Pull Request
Title
Updated the About Us page
Description
Updated the About Us page and made it fully responsive for all devices and dimensions
Added Interactive and sleek animations
Fixed the spacings
Related Issues
Fixes #346
Changes Made
New Features and bug fixes
Checklist
Screenshots (if applicable)
Video Demo
possssssssssssssssssssst.mp4
These are the screenshots
Additional Notes
Footer